From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [RFC] set MS_NOATIME on FAT ? Date: Wed, 16 Mar 2005 00:58:10 +0900 Message-ID: <87zmx4x5nx.fsf@devron.myhome.or.jp> References: <20050314232059.R12802@almesberger.net> <871xahwoik.fsf@devron.myhome.or.jp> <20050315011820.S12802@almesberger.net> <87wts9mr7s.fsf@devron.myhome.or.jp> <20050315080407.T12802@almesberger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Received: from mail.parknet.co.jp ([210.171.160.6]:19723 "EHLO mail.parknet.co.jp") by vger.kernel.org with ESMTP id S261345AbVCOP6z (ORCPT ); Tue, 15 Mar 2005 10:58:55 -0500 To: Werner Almesberger In-Reply-To: <20050315080407.T12802@almesberger.net> (Werner Almesberger's message of "Tue, 15 Mar 2005 08:04:07 -0300") Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Werner Almesberger writes: > In the case of non-VFAT, there's also the issue that pretending to > support atime causes atime to jump back and forth unpredictably, > depending on when the inode is evicted from memory. (And the low > adate resolution means that even VFAT will have a similar problem.) Yes. We would need to add something to timespec_trunc() for it. And unfortunately de->time too. > But I guess if nobody complained in the last twelve or so years, > we're in no hurry to fix that ;-) Thanks. :) > @@ -1059,6 +1131,8 @@ int fat_fill_super(struct super_block *s > memset(sbi, 0, sizeof(struct msdos_sb_info)); > > sb->s_flags |= MS_NODIRATIME; > + if (!isvfat) > + sb->s_flags |= MS_NOATIME; > sb->s_magic = MSDOS_SUPER_MAGIC; > sb->s_op = &fat_sops; > sb->s_export_op = &fat_export_ops; Looks good to me. But, I don't know whether actually DOS updates ->adate or not. It would depend on it. Thanks. -- OGAWA Hirofumi