From: "J. R. Okajima" <hooanon05@yahoo.co.jp>
To: Nick Piggin <npiggin@gmail.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: vfs-scale, d_revalidate from nfsd
Date: Thu, 13 Jan 2011 23:03:56 +0900 [thread overview]
Message-ID: <8855.1294927436@jrobl> (raw)
NFSD calls filesystem's ->d_revalidate() with the parameter nd == NULL.
So every
if (nd->flags & LOOKUP_RCU)
return -ECHILD;
code which was added to ->d_revalidate() of FS which supports NFS
exporting will crash.
If we rewrite it as
if (nd && (nd->flags & LOOKUP_RCU))
return -ECHILD;
the problem may not occur.
But I am not sure whether lookup_one_len() call in NFSD support rcu-walk.
J. R. Okajima
next reply other threads:[~2011-01-13 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 14:03 J. R. Okajima [this message]
2011-01-14 2:57 ` vfs-scale, d_revalidate from nfsd Nick Piggin
2011-01-14 3:03 ` Al Viro
2011-01-14 3:12 ` Nick Piggin
2011-01-14 3:20 ` Al Viro
2011-01-14 3:22 ` Al Viro
2011-01-14 3:29 ` Nick Piggin
2011-01-14 3:38 ` Al Viro
2011-01-15 3:47 ` J. R. Okajima
2011-01-15 18:11 ` Nick Piggin
2011-02-15 5:07 ` J. R. Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8855.1294927436@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).