From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, Eric Sandeen <sandeen@sandeen.net>
Subject: Re: The XFS_IOC_FSGEOMETRY ioctl doesn't like fds that are opened O_PATH
Date: Thu, 30 Mar 2017 09:03:54 +0100 [thread overview]
Message-ID: <8867.1490861034@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170330025620.GA789@zzz>
Eric Biggers <ebiggers3@gmail.com> wrote:
> Also, ioctl() with an O_PATH file descriptor always fails with EBADF because
> sys_ioctl() uses fdget() rather than fdget_raw(). The filesystem isn't
> involved at all. This is intentional, I believe.
Yeah. Apparently so, though some ioctls might make sense if they're asking
about the filesystem.
Anyway, I need to fix xfs_io for that now too if I'm going to use that. I
wonder what xfs_io needs the geometry for.
I'm getting the impression xfs_io isn't really the tool I should be using for
this.
Dvid
next prev parent reply other threads:[~2017-03-30 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 14:29 [PATCH] xfs_io: Allow "open -P" to specify O_PATH David Howells
2017-03-29 21:52 ` [PATCH] xfs_io: Allow -P and -L to be given to open for O_PATH and O_NOFOLLOW David Howells
2018-03-02 3:27 ` Eric Sandeen
2017-03-29 23:57 ` The XFS_IOC_FSGEOMETRY ioctl doesn't like fds that are opened O_PATH David Howells
2017-03-30 0:23 ` Darrick J. Wong
2017-03-30 2:56 ` Eric Biggers
2017-03-30 3:25 ` Darrick J. Wong
2017-03-30 8:03 ` David Howells [this message]
2017-03-30 16:29 ` [PATCH] xfs_io: Allow "open -P" to specify O_PATH Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8867.1490861034@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=ebiggers3@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).