From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8371DC4332F for ; Sun, 27 Feb 2022 21:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232009AbiB0WAT (ORCPT ); Sun, 27 Feb 2022 17:00:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbiB0WAQ (ORCPT ); Sun, 27 Feb 2022 17:00:16 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0E56AA76 for ; Sun, 27 Feb 2022 13:59:38 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id o23so9791967pgk.13 for ; Sun, 27 Feb 2022 13:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZrKI3DSZdTxekUPySsEMaohdk0Ebr8lmd+pDdB2Ygvc=; b=AEhyForKjbDZKEq/PFv6p/G2ZB3dSs895NqBGgn0JW1Tpv1osByHflyrOYUBKFe77q rEzyndlbiiho8KtHMqzE7la0X+pbnixp070cQjW5ARtttgU/Am64dO7sDyfRknxLrR3K B5709/Td+SGSynJoMRndSLIvppWg0zHQ/RNreCH4AAiQbKAvmExz7Q5DXgKbdUajZAdz 6GSAmhxXaOW1i2nQEZWU8VAkNeBD9W+wTXXgmD0ohNTFh0XI/Ziv8rrDbVUm955l6TZL 0ByyWm6Mlf4+963avEfu65LwMhX6InrJK8z7CPhZ9K5MzRYcNmotW4008jGVKXEw8WvJ gqKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZrKI3DSZdTxekUPySsEMaohdk0Ebr8lmd+pDdB2Ygvc=; b=cp7COUf9u/gjqLOVRVUMLwuqQmuuui/fCVzSRSL8S0VRsnqYw/fVw+rKzOzd5D198e XDvkoxwgt+5hI1I6Z1ho7s5t7uiggLZL8fbkYqcxWbENQ/0qsP2f5p4+GOjoV1SSDu17 jaDGYD3nJPt2RFHXwu1KPPzL3kQfK8Z4eTk5m31N+348JkBPGF7jAzzszdHcwqhIJXl2 RuXCAgfuJ+4yYztTBGjHj0s2nwDoWxM8EcSAmLe3tHY+fRmOy9gQJUsJwdMjtrYj/Iha 3i5eG6yoWpcfshgICBvtIRZ3hIDSrHjHmNgg6SPbNJhih2BhXofDP7QXAY65C5dkHthU kvcw== X-Gm-Message-State: AOAM530UquC+GE/DZB4gw5fmDfHeltFIzLoyYcE0hfbiXb0ObwxG7v1q 8CDsAsW8vshN3FOnYC7zRpbfmA== X-Google-Smtp-Source: ABdhPJyaSQFLGaa+8maa8wDtePuQmdliyTg6t1OPFEjFv3DiD8FgQGuKlD2bA9CLsLw5mSJh0YHR0g== X-Received: by 2002:a05:6a00:8ca:b0:4e0:2ed3:5630 with SMTP id s10-20020a056a0008ca00b004e02ed35630mr18547182pfu.3.1645999178369; Sun, 27 Feb 2022 13:59:38 -0800 (PST) Received: from [192.168.4.166] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id f31-20020a631f1f000000b003742e45f7d7sm8492806pgf.32.2022.02.27.13.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 13:59:37 -0800 (PST) Message-ID: <8b5b35fa-3c70-adc8-ca3a-4829388c4d12@kernel.dk> Date: Sun, 27 Feb 2022 14:59:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 4/6] block, bio, fs: convert most filesystems to pin_user_pages_fast() Content-Language: en-US To: jhubbard.send.patches@gmail.com, Jan Kara , Christoph Hellwig , Dave Chinner , "Darrick J . Wong" , Theodore Ts'o , Alexander Viro , Miklos Szeredi , Andrew Morton , Chaitanya Kulkarni Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, LKML , John Hubbard References: <20220227093434.2889464-1-jhubbard@nvidia.com> <20220227093434.2889464-5-jhubbard@nvidia.com> From: Jens Axboe In-Reply-To: <20220227093434.2889464-5-jhubbard@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2/27/22 2:34 AM, jhubbard.send.patches@gmail.com wrote: > From: John Hubbard > > Use pin_user_pages_fast(), pin_user_page(), and unpin_user_page() calls, > in place of get_user_pages_fast(), get_page() and put_page(). > > This converts the Direct IO parts of most filesystems over to using > FOLL_PIN (pin_user_page*()) page pinning. The commit message needs to explain why a change is being made, not what is being done. The latter I can just look at the code for. Didn't even find it in in your cover letter, had to go to the original posting for that. -- Jens Axboe