From: Paolo Bonzini <pbonzini@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
kvm@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, mst@redhat.com, borntraeger@de.ibm.com
Subject: Re: [RFC PATCH 2/5] statsfs API: create, add and remove statsfs sources and values
Date: Wed, 29 Apr 2020 12:34:51 +0200 [thread overview]
Message-ID: <8c979c8b-be64-a18c-2223-2964cb96d52a@redhat.com> (raw)
In-Reply-To: <229d83bf-1272-587b-233a-d68ad2e11cde@infradead.org>
On 28/04/20 19:47, Randy Dunlap wrote:
>> +config STATS_FS
>> + bool "Statistics Filesystem"
>> + default y
> Not default y. We don't enable things that are not required.
> Unless you have a convincing argument otherwise.
>
I think the best solution is to add stubs to include/linux/statsfs.h,
and use "imply STATS_FS" in KVM. This would still "default y" when
a subsystem that uses the filesystem is in use, but not otherwise.
Paolo
next prev parent reply other threads:[~2020-04-29 10:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:18 [RFC PATCH 0/5] Statsfs: a new ram-based file sytem for Linux kernel statistics Emanuele Giuseppe Esposito
2020-04-27 14:18 ` [RFC PATCH 1/5] refcount, kref: add dec-and-test wrappers for rw_semaphores Emanuele Giuseppe Esposito
2020-04-27 14:18 ` [RFC PATCH 2/5] statsfs API: create, add and remove statsfs sources and values Emanuele Giuseppe Esposito
2020-04-27 15:47 ` Matthew Wilcox
2020-04-27 16:48 ` Emanuele Giuseppe Esposito
2020-04-29 9:49 ` [RFC PATCH 2/5] statsfs API: create, add and remove statsfs Emanuele Giuseppe Esposito
2020-04-27 21:53 ` [RFC PATCH 2/5] statsfs API: create, add and remove statsfs sources and values Andreas Dilger
2020-04-29 10:55 ` Emanuele Giuseppe Esposito
2020-04-28 17:47 ` Randy Dunlap
2020-04-29 10:34 ` Paolo Bonzini [this message]
2020-04-27 14:18 ` [RFC PATCH 3/5] kunit: tests for statsfs API Emanuele Giuseppe Esposito
2020-04-28 17:50 ` Randy Dunlap
2020-04-27 14:18 ` [RFC PATCH 4/5] statsfs fs: virtual fs to show stats to the end-user Emanuele Giuseppe Esposito
2020-04-27 14:18 ` [RFC PATCH 5/5] kvm_main: replace debugfs with statsfs Emanuele Giuseppe Esposito
2020-04-28 17:56 ` Randy Dunlap
2020-04-29 10:34 ` Emanuele Giuseppe Esposito
2020-04-29 10:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c979c8b-be64-a18c-2223-2964cb96d52a@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=eesposit@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).