From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE99C83003 for ; Wed, 29 Apr 2020 10:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D49E21D7B for ; Wed, 29 Apr 2020 10:34:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EopDhrRz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbgD2Ke7 (ORCPT ); Wed, 29 Apr 2020 06:34:59 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:60017 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726516AbgD2Ke5 (ORCPT ); Wed, 29 Apr 2020 06:34:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588156496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MvG6U9Dx9wY0k8COf5NQcI7j1f22+LOgfSM/YdEK4/U=; b=EopDhrRzW5fDL7cg6oZ4PdvCvmp9wbrWxW0tPdYhYEe2vUKVb7l3Qcgwkpe7hVTa8maM0i vuSfc/mUVEvp2e54u6WoH8AlhzGveNBsOTZpvPQuddT7JBCGz9MMjxUMbnhGffkwz0sdhY xwGe+FWECcTQNrJWGhHQ8QwiIGN8Zoo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-AGMaVyflNNmtEo2uGRbULw-1; Wed, 29 Apr 2020 06:34:54 -0400 X-MC-Unique: AGMaVyflNNmtEo2uGRbULw-1 Received: by mail-wr1-f70.google.com with SMTP id m5so1495351wru.15 for ; Wed, 29 Apr 2020 03:34:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MvG6U9Dx9wY0k8COf5NQcI7j1f22+LOgfSM/YdEK4/U=; b=FXKBFjJliTjIVbvNtDKjaMO+DlKRoPdF4cuVpV1PKvzl60spHaIGtyWesT/SJxpCPl tJ/CSvUJFxTU2Eouov+p/uyn+W4Out4HmoWrQNkiv8zNtoBnzRLKwR+kbCrXqJldMOq9 uKXFwf1zCOtA46tgue+PeQ8TzE9wdLtcC2V7QLj4iUvFqEzZWwHMB811OGaZx6XQKENb PTF/gBeTgk0TDRuQJT99nrgWkTghZZmX85adiaIsmBDlS97J/T0eMSjVvlCgl6DOl5x+ cl4QpfqyMBizrTy7DfamVAn63nN/kjjQsji8372WYhv8RFHsQW30H6RdH0EAnxXjOSfA TStg== X-Gm-Message-State: AGi0PubP6ihIBUjODfBWXK4cS5wZxrfgyE3ri4zULiJ8g2SaFvd6UuWi 6U4n/GskOsvXkS0P4v+o9/i1n5rAte6yDALc2K96KZSCBsQDCVwZXw8/fZZO1skLoXhwZ4Z8G1l PMApPGqIIVr4lnme/gPcVP0c0uA== X-Received: by 2002:adf:ea44:: with SMTP id j4mr41471880wrn.38.1588156493399; Wed, 29 Apr 2020 03:34:53 -0700 (PDT) X-Google-Smtp-Source: APiQypKsv04Kl2n9Ejnnl4yI4d1AM613mOCDgy0cvtYoIwAIk6yB89ianzTeiVeeOXFJb7+gpM/E8g== X-Received: by 2002:adf:ea44:: with SMTP id j4mr41471860wrn.38.1588156493155; Wed, 29 Apr 2020 03:34:53 -0700 (PDT) Received: from [192.168.10.150] ([93.56.170.5]) by smtp.gmail.com with ESMTPSA id v7sm6952037wmg.3.2020.04.29.03.34.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 03:34:52 -0700 (PDT) Subject: Re: [RFC PATCH 2/5] statsfs API: create, add and remove statsfs sources and values To: Randy Dunlap , Emanuele Giuseppe Esposito , kvm@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, mst@redhat.com, borntraeger@de.ibm.com References: <20200427141816.16703-1-eesposit@redhat.com> <20200427141816.16703-3-eesposit@redhat.com> <229d83bf-1272-587b-233a-d68ad2e11cde@infradead.org> From: Paolo Bonzini Message-ID: <8c979c8b-be64-a18c-2223-2964cb96d52a@redhat.com> Date: Wed, 29 Apr 2020 12:34:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <229d83bf-1272-587b-233a-d68ad2e11cde@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 28/04/20 19:47, Randy Dunlap wrote: >> +config STATS_FS >> + bool "Statistics Filesystem" >> + default y > Not default y. We don't enable things that are not required. > Unless you have a convincing argument otherwise. > I think the best solution is to add stubs to include/linux/statsfs.h, and use "imply STATS_FS" in KVM. This would still "default y" when a subsystem that uses the filesystem is in use, but not otherwise. Paolo