From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63208C43381 for ; Tue, 19 Mar 2019 13:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E5822133D for ; Tue, 19 Mar 2019 13:38:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727143AbfCSNi6 (ORCPT ); Tue, 19 Mar 2019 09:38:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35622 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726661AbfCSNi6 (ORCPT ); Tue, 19 Mar 2019 09:38:58 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FE0513AAE for ; Tue, 19 Mar 2019 13:38:58 +0000 (UTC) Received: from [10.33.36.12] (unknown [10.33.36.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22D3D5D70D; Tue, 19 Mar 2019 13:38:54 +0000 (UTC) Subject: Re: [PATCH 1/2] gfs2: Convert gfs2 to fs_context To: David Howells Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org References: <8b0534dc-0ee0-ba7f-8709-30433c04c5a7@redhat.com> <20190317174027.15291-2-anprice@redhat.com> <20190317174027.15291-1-anprice@redhat.com> <28293.1552915099@warthog.procyon.org.uk> <27152.1552950072@warthog.procyon.org.uk> From: Andrew Price Message-ID: <8d27b734-f9bf-bceb-c6f8-791d088bd11e@redhat.com> Date: Tue, 19 Mar 2019 13:38:54 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <27152.1552950072@warthog.procyon.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 19 Mar 2019 13:38:58 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 18/03/2019 23:01, David Howells wrote: > Andrew Price wrote: > >>> Umm... What about the fs_context struct? Why can't that be used to >>> propagate the bdev pointer? That's kind of what it's for... >> >> It would be useful to have the block device pointer in the fs_context since so >> many of the filesystems use them and it makes for an obvious API migration. > > That may be so. I've argued also that we should put a net-namespace pointer > in there, but Al disagreed. > > However, I think most bdev-based filesystems use mount_bdev() which gfs2 does > not. > >>> It looks like you should be able to stash the bdev pointer in the gfs2_args >>> struct. >> >> Sure, but since the new API is young I figured I'd hold off until we had this >> conversation because adding it to the fs_context might be agreeable :) > > Note that I have patches to kill of sget_userns() and sget() will hopefully > soon follow. Have a look at: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=mount-api-viro That's fair enough. I'll update the patch to put the bdev in the gfs2_args struct and use sget_fc(). Thanks, Andy