From: Bart Van Assche <bvanassche@acm.org>
To: Randy Dunlap <rdunlap@infradead.org>, linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] fs/hfsplus: wrapper.c: fix kernel-doc warnings
Date: Fri, 9 Feb 2024 13:57:22 -0800 [thread overview]
Message-ID: <8e6759b1-15da-40b7-85a5-7c6ae91d51e5@acm.org> (raw)
In-Reply-To: <20231206024317.31020-1-rdunlap@infradead.org>
On 12/5/23 18:43, Randy Dunlap wrote:
> - * @op: direction of I/O
> - * @op_flags: request op flags
> + * @opf: request op flags
(just noticed this patch)
The new comment is worse than the original comments. This would be a
better explanation of the 'opf' argument:
+ * @opf: I/O operation type and flags
Thanks,
Bart.
next prev parent reply other threads:[~2024-02-09 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 2:43 [PATCH] fs/hfsplus: wrapper.c: fix kernel-doc warnings Randy Dunlap
2023-12-08 13:15 ` Christian Brauner
2024-02-09 21:57 ` Bart Van Assche [this message]
2024-02-10 4:59 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e6759b1-15da-40b7-85a5-7c6ae91d51e5@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).