From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Christian Brauner <brauner@kernel.org>,
Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>, Gao Xiang <xiang@kernel.org>,
Song Liu <song@kernel.org>
Subject: Re: Stacking filesystem deadlocks [was Re: Fanotify (hsm or erofs) / fuse / nbd / ... + write(mmap) deadlock vector followup]
Date: Wed, 17 Jun 2026 22:23:22 +0800 [thread overview]
Message-ID: <905b7d03-3e35-4db5-b72e-51051b034cf4@linux.alibaba.com> (raw)
In-Reply-To: <20260617-vorfahren-haften-nullnummer-b0d6fccadae3@brauner>
On 2026/6/17 21:37, Christian Brauner wrote:
> On Thu, Jun 11, 2026 at 05:25:56PM +0200, Amir Goldstein wrote:
>> On Thu, Jun 11, 2026 at 1:32 PM Jan Kara <jack@suse.cz> wrote:
...
>>
>> My crystal ball tells me we are probably not going to do that :-/
>> But if we did, it would have been nice to validate that LOOP_CHANGE_FD
>> does not set the backing file of loopA to a file on fsB ;)
>
> LOOP_CHANGE_FD should be removed. I proposed that years ago because it's
> problematic in other ways. Everyone agreed as it was effectively unused
> I just never bothered pushing it through. So let's not worry about that
> let's kill it instead. Here's the patch from 2023:
>
> From 46db77d781d329b7fc7b3245dd295a69026f6ec0 Mon Sep 17 00:00:00 2001
> From: Christian Brauner <brauner@kernel.org>
> Date: Mon, 6 Nov 2023 16:29:32 +0100
> Subject: [PATCH] loop: remove support for swapping loop fds
>
> We did not find any users of LOOP_CHANGE_FD.
>
> Signed-off-by: Christian Brauner <brauner@kernel.org>
I am glad if it could be dropped so at least I will not
worry about missing features if fs shutdown is
implemented in erofs.
Thanks,
Gao Xiang
next prev parent reply other threads:[~2026-06-17 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <271c1c26-f170-462b-8a7f-686530fdd449@linux.alibaba.com>
[not found] ` <53d0e50a-faa9-49e4-a8f5-d4d37bcba0c6@linux.alibaba.com>
[not found] ` <CAOQ4uxh-kmoO03yCPaFnWcMjeOgqUi_19cGg4qdeY86ccz9ZyA@mail.gmail.com>
[not found] ` <f0adaed4-1412-4722-8bdd-53f5e3823209@linux.alibaba.com>
[not found] ` <CAOQ4uxj7gP=qpUvVbMbxbf6LdrYLeB4dX=vkUfOpi1ZfU0542Q@mail.gmail.com>
[not found] ` <CAJfpeguXSh3-_3cbpzS-s4+Bq+7MVwazD+3P-diG=Qq70E2qrQ@mail.gmail.com>
[not found] ` <d5f62836-62d1-4b8e-9694-bbab27112e7e@linux.alibaba.com>
[not found] ` <649fdbbb-64f7-43d9-afd5-a3076e3ec946@linux.alibaba.com>
[not found] ` <CAOQ4uxj+WAe+99FFi9RfMd5tpSwwP=rSH4dNuJEdhV1wL+5CDA@mail.gmail.com>
[not found] ` <dff837f6-7480-4984-8728-802ddd78dda4@linux.alibaba.com>
[not found] ` <CAOQ4uxi7DceKuh6+qGjuQJEFiE=HEFu4dMrc++VXUknRnX26JQ@mail.gmail.com>
[not found] ` <95371379-97e9-4cb4-8358-ec014b765b74@linux.alibaba.com>
[not found] ` <CAOQ4uxjh5VYkKLAKxhMsy-ZmrbRrgX4pFgBLFqsDqWMXeiqg3w@mail.gmail.com>
[not found] ` <ac05da56-eb2a-4862-b887-8081f249d8ce@linux.alibaba.com>
[not found] ` <CAOQ4uxi0yRavUeztRh-Eb8_HvpfmqkpPbWT9JgQhUn7EKXnryw@mail.gmail.com>
2026-06-10 8:17 ` Fanotify (hsm or erofs) / fuse / nbd / ... + write(mmap) deadlock vector followup Gao Xiang
2026-06-10 12:21 ` Stacking filesystem deadlocks [was Re: Fanotify (hsm or erofs) / fuse / nbd / ... + write(mmap) deadlock vector followup] Jan Kara
2026-06-10 13:18 ` Gao Xiang
2026-06-10 15:40 ` Amir Goldstein
2026-06-10 15:58 ` Gao Xiang
2026-06-11 11:32 ` Jan Kara
2026-06-11 15:25 ` Amir Goldstein
2026-06-17 13:37 ` Christian Brauner
2026-06-17 14:23 ` Gao Xiang [this message]
2026-06-17 17:09 ` Jan Kara
2026-06-19 7:25 ` Christian Brauner
2026-06-17 17:33 ` Jan Kara
2026-06-17 18:04 ` Gao Xiang
2026-06-19 7:27 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905b7d03-3e35-4db5-b72e-51051b034cf4@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=song@kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox