From: "Mark Asselstine" <asselsm@gmail.com>
To: "Manish Katiyar" <mkatiyar@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext2 : Remove redundant condition in ext2_free_blocks()
Date: Tue, 3 Jun 2008 08:33:20 -0400 [thread overview]
Message-ID: <919fe2b30806030533yce91ceds67b942f3adf88afb@mail.gmail.com> (raw)
In-Reply-To: <ea11fea30805311156o3715d3f9ibd4ea8b44a8f3223@mail.gmail.com>
On Sat, May 31, 2008 at 2:56 PM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> For two unsigned values the check "block+count < block" is always
> false. Thus the below patch removes that condition.
>
Always? What about "ULONG_MAX + 5"? I believe the answer is 4, but I
may be wrong. You might want to rethink this one.
RE/
Mark
> =============================================================
>
> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
>
> --- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
> +++ b/fs/ext2/balloc.c 2008-06-01 00:03:44.000000000 +0530
> @@ -499,7 +499,6 @@
> unsigned freed = 0, group_freed;
>
> if (block < le32_to_cpu(es->s_first_data_block) ||
> - block + count < block ||
> block + count > le32_to_cpu(es->s_blocks_count)) {
> ext2_error (sb, "ext2_free_blocks",
> "Freeing blocks not in datazone - "
>
>
> =============================================================
>
> --
> Thanks & Regards,
> ********************************************
> Manish Katiyar ( http://mkatiyar.googlepages.com )
> 3rd Floor, Fair Winds Block
> EGL Software Park
> Off Intermediate Ring Road
> Bangalore 560071, India
> ***********************************************
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-06-03 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-31 18:56 [PATCH] ext2 : Remove redundant condition in ext2_free_blocks() Manish Katiyar
2008-06-03 12:33 ` Mark Asselstine [this message]
2008-06-03 13:28 ` Manish Katiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=919fe2b30806030533yce91ceds67b942f3adf88afb@mail.gmail.com \
--to=asselsm@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mkatiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).