linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "rae l" <crquan@gmail.com>
To: "Ray Lee" <ray-lk@madrabbit.org>
Cc: "Matthew Wilcox" <matthew@wil.cx>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: It's time to hack on dentry_stat?
Date: Thu, 8 May 2008 00:32:28 +0800	[thread overview]
Message-ID: <91b13c310805070932s439ce4bbsfe0d658c406b55c7@mail.gmail.com> (raw)
In-Reply-To: <2c0942db0805070910w6b304d3cye8848d5c03462aa2@mail.gmail.com>

On Thu, May 8, 2008 at 12:10 AM, Ray Lee <ray-lk@madrabbit.org> wrote:
>  <shrug> Well, if there's one, then obviously there isn't. I'd assumed
>  it was a per-dentry overhead.

Good. If the binary application interface must be kept,
>  $ cat /proc/sys/fs/dentry-state
>  122104  115846  45      0       0       0
and to shrink dentry_stat can only save 16 bytes, there's no need to do this,

but the Documentation/ as this should be fixed?

Documentation/filesystems/proc.txt:

dentry-state
------------

Status of  the  directory  cache.  Since  directory  entries  are  dynamically
allocated and  deallocated,  this  file indicates the current status. It holds
six values, in which the last two are not used and are always zero. The others
are listed in table 2-1.

Table 2-1: Status files of the directory cache
..............................................................................
 File       Content
 nr_dentry  Almost always zero
 nr_unused  Number of unused cache entries
 age_limit
            in seconds after the entry may be reclaimed, when memory is short
 want_pages internally
..............................................................................

the age_limit and want_pages should be marked outdated and not used anymore,

But there's still one question:
1. Is age_limit always 45? Or the binary application interface would
expect it always 45?
   Can we change dentry_stat with 6 int values all initialized with
zero? Then the docs can be
   fixed with last four values not used and are always zero.

--
Cheng

      reply	other threads:[~2008-05-07 16:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07 14:26 It's time to hack on dentry_stat? rae l
2008-05-07 14:51 ` Matthew Wilcox
2008-05-07 15:06   ` rae l
2008-05-07 15:08   ` Ray Lee
2008-05-07 15:25     ` Matthew Wilcox
2008-05-07 16:10       ` Ray Lee
2008-05-07 16:32         ` rae l [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b13c310805070932s439ce4bbsfe0d658c406b55c7@mail.gmail.com \
    --to=crquan@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=ray-lk@madrabbit.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).