From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: Patch: romfs_lookup always failed in linux-2.6.25-rc3-git3 Date: Tue, 04 Mar 2008 22:25:56 +0000 Message-ID: <9258.1204669556@redhat.com> References: <20080304184009.GB24301@freya.fugue.com> <20080303173620.GA9243@freya.fugue.com> <5368.1204641163@redhat.com> Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "Adam J. Richter" Return-path: Received: from mx1.redhat.com ([66.187.233.31]:54011 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764205AbYCDWZ7 (ORCPT ); Tue, 4 Mar 2008 17:25:59 -0500 In-Reply-To: <20080304184009.GB24301@freya.fugue.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Adam J. Richter wrote: > My only question is why you've changed res from int to long, given that > you've corrected my misguided "P.S.": Because if you compile for a 64-bit system, you may find extra instructions emitted, at the very least in ERR_PTR(res) where it turns a 32-bit int into a 64-bit pointer. David