From: "Adrian McMenamin" <adrian@newgolddream.dyndns.info>
To: "Evgeniy Polyakov" <zbr@ioremap.net>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] filesystem: VMUFAT filesystem
Date: Sun, 15 Feb 2009 16:43:52 -0000 (UTC) [thread overview]
Message-ID: <936fa6a7e76b86c08b843b6531d27861.squirrel@newgolddream.dyndns.info> (raw)
In-Reply-To: <20090215150335.GA15736@ioremap.net>
On Sun, February 15, 2009 3:03 pm, Evgeniy Polyakov wrote:
> Hi Adrian.
Hi
>
> That's all for now. Overall there is a fair numebr of leaks
> because of the missed freeing in the error path and lots of duplicated
> code because of the multiple error exit points. Also you frequently do
> not check the return value of the functions which may fail.
>
> --
> Evgeniy Polyakov
>
Thanks for the comments. Very useful. I ported this over from some truly
abysmal code I'd written years ago and clearly didn't do a good enough job
:)
next prev parent reply other threads:[~2009-02-15 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 21:16 [RFC][PATCH] filesystem: VMUFAT filesystem Adrian McMenamin
2009-02-15 15:03 ` Evgeniy Polyakov
2009-02-15 16:43 ` Adrian McMenamin [this message]
2009-02-16 3:15 ` Paul Mundt
2009-02-16 8:07 ` Adrian McMenamin
2009-02-27 13:26 ` Pavel Machek
2009-03-05 10:59 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=936fa6a7e76b86c08b843b6531d27861.squirrel@newgolddream.dyndns.info \
--to=adrian@newgolddream.dyndns.info \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).