From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Adrian McMenamin" Subject: Re: [RFC][PATCH] filesystem: VMUFAT filesystem Date: Sun, 15 Feb 2009 16:43:52 -0000 (UTC) Message-ID: <936fa6a7e76b86c08b843b6531d27861.squirrel@newgolddream.dyndns.info> References: <1234646219.6609.37.camel@localhost.localdomain> <20090215150335.GA15736@ioremap.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, "LKML" To: "Evgeniy Polyakov" Return-path: Received: from mk-filter-3-a-1.mail.uk.tiscali.com ([212.74.100.54]:13884 "EHLO mk-filter-3-a-1.mail.uk.tiscali.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753182AbZBOQoT (ORCPT ); Sun, 15 Feb 2009 11:44:19 -0500 In-Reply-To: <20090215150335.GA15736@ioremap.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, February 15, 2009 3:03 pm, Evgeniy Polyakov wrote: > Hi Adrian. Hi > > That's all for now. Overall there is a fair numebr of leaks > because of the missed freeing in the error path and lots of duplicated > code because of the multiple error exit points. Also you frequently do > not check the return value of the functions which may fail. > > -- > Evgeniy Polyakov > Thanks for the comments. Very useful. I ported this over from some truly abysmal code I'd written years ago and clearly didn't do a good enough job :)