From: Jeff Layton <jlayton@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: viro@zeniv.linux.org.uk,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Scott Mayhew <smayhew@redhat.com>,
Paul Moore <paul@paul-moore.com>,
Casey Schaufler <casey@schaufler-ca.com>,
linux-nfs@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dwysocha@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing
Date: Tue, 06 Sep 2022 12:02:55 -0400 [thread overview]
Message-ID: <93ff2f6d8c49091c0aa8a008695da5150c096be3.camel@kernel.org> (raw)
In-Reply-To: <3349244.1662480110@warthog.procyon.org.uk>
On Tue, 2022-09-06 at 17:01 +0100, David Howells wrote:
> Jeff Layton <jlayton@kernel.org> wrote:
>
> > If this or the other allocations below fail, do you need to free the
> > prior ones here? Or do they automagically get cleaned up somehow?
>
> Once the fs_context is allocated, it will always get cleaned up with
> put_fs_context(), which will dispose of the partially constructed
> smack_mnt_opts struct.
>
Ok! In that case, you can add:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-09-06 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 12:02 [PATCH v5] vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing David Howells
2022-09-01 14:13 ` Christian Brauner
2022-09-06 15:48 ` Jeff Layton
2022-09-06 16:01 ` David Howells
2022-09-06 16:02 ` Jeff Layton [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-10 11:09 David Howells
2022-11-11 17:40 ` Paul Moore
2022-11-11 17:43 ` Paul Moore
2022-11-19 8:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93ff2f6d8c49091c0aa8a008695da5150c096be3.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=dhowells@redhat.com \
--cc=dwysocha@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).