From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Eric Biggers <ebiggers@kernel.org>,
"fsverity@lists.linux.dev" <fsverity@lists.linux.dev>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fsverity: use WARN_ON_ONCE instead of WARN_ON
Date: Tue, 28 Mar 2023 06:15:59 +0000 [thread overview]
Message-ID: <962dab64-8010-26b5-a8d9-872fc27dce3e@nvidia.com> (raw)
In-Reply-To: <20230328040326.105018-1-ebiggers@kernel.org>
On 3/27/23 21:03, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> As per Linus's suggestion
> (https://lore.kernel.org/r/CAHk-=whefxRGyNGzCzG6BVeM=5vnvgb-XhSeFJVxJyAxAF8XRA@mail.gmail.com),
> use WARN_ON_ONCE instead of WARN_ON. This barely adds any extra
> overhead, and it makes it so that if any of these ever becomes reachable
> (they shouldn't, but that's the point), the logs can't be flooded.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2023-03-28 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 4:03 [PATCH] fsverity: use WARN_ON_ONCE instead of WARN_ON Eric Biggers
2023-03-28 6:15 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962dab64-8010-26b5-a8d9-872fc27dce3e@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).