From: David Howells <dhowells@redhat.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@osdl.org>,
Mark Fasheh <mark.fasheh@oracle.com>,
dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [-mm PATCH] ocfs2: Shared writeable mmap
Date: Tue, 20 Jun 2006 13:59:44 +0100 [thread overview]
Message-ID: <9630.1150808384@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <1150787267.28517.126.camel@lappy>
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> - if (unlikely(vma->vm_flags & VM_SHARED)) {
> + if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
> + VM_SHARED|VM_WRITE) {
NAK!
"==" is higher priority than "|". What you meant was:
- if (unlikely(vma->vm_flags & VM_SHARED)) {
+ if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
+ (VM_SHARED|VM_WRITE)) {
David
next prev parent reply other threads:[~2006-06-20 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 23:46 [-mm PATCH] ocfs2: Shared writeable mmap Mark Fasheh
2006-06-19 23:55 ` [Ocfs2-devel] " Daniel Phillips
2006-06-20 5:42 ` Mark Fasheh
2006-06-20 0:07 ` Andrew Morton
2006-06-20 0:52 ` Mark Fasheh
2006-06-20 7:07 ` Peter Zijlstra
2006-06-20 12:59 ` David Howells [this message]
2006-06-20 13:02 ` David Howells
2006-06-20 13:20 ` [PATCH] Add notification of page becoming writable to VMA ops David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9630.1150808384@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mark.fasheh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).