From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [RFC][PATCH 04/10] cifs: define server-level cache index objects and register them with FS-Cache Date: Wed, 23 Jun 2010 17:54:52 +0100 Message-ID: <9658.1277312092@redhat.com> References: <1277220198-3522-1-git-send-email-sjayaraman@suse.de> Cc: dhowells@redhat.com, Steve French , linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Suresh Jayaraman Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794Ab0FWQzB (ORCPT ); Wed, 23 Jun 2010 12:55:01 -0400 In-Reply-To: <1277220198-3522-1-git-send-email-sjayaraman@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Suresh Jayaraman wrote: > Define server-level cache index objects (as managed by TCP_ServerInfo > structs). Each server object is created in the CIFS top-level index object > and is itself an index into which superblock-level objects are inserted. > > Currently, the server objects are keyed by hostname. > > Signed-off-by: Suresh Jayaraman Looks reasonable, apart from the index key. I agree with Jeff that you probably want {address,port,family} rather than a hostname. David