From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@redhat.com>
Subject: Re: [-mm PATCH] ocfs2: Shared writeable mmap
Date: Tue, 20 Jun 2006 14:02:25 +0100
Message-ID: <9710.1150808545@warthog.cambridge.redhat.com>
References: <9630.1150808384@warthog.cambridge.redhat.com>  <1150787267.28517.126.camel@lappy> <20060619234643.GK3082@ca-server1.us.oracle.com> <20060619170736.65237ce7.akpm@osdl.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@osdl.org>,
	Mark Fasheh <mark.fasheh@oracle.com>,
	linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:12493 "EHLO mx1.redhat.com")
	by vger.kernel.org with ESMTP id S1750753AbWFTNCi (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 20 Jun 2006 09:02:38 -0400
In-Reply-To: <9630.1150808384@warthog.cambridge.redhat.com> 
To: David Howells <dhowells@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

David Howells <dhowells@redhat.com> wrote:

> Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> 
> > -	if (unlikely(vma->vm_flags & VM_SHARED)) {
> > +	if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
> > +				VM_SHARED|VM_WRITE) {
> 
> NAK!
> 
> "==" is higher priority than "|".  What you meant was:
> 
> -	if (unlikely(vma->vm_flags & VM_SHARED)) {
> +	if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
> +				(VM_SHARED|VM_WRITE)) {

Or, rather:

-	if (unlikely(vma->vm_flags & VM_SHARED)) {
+	if (unlikely(vma->vm_flags & (VM_SHARED|VM_WRITE) ==
+				(VM_SHARED|VM_WRITE))) {

It has insufficient closing brackets otherwise.

David