Re: [PATCH 04/11] gfs2: Don't clear SGID when inheriting ACLs

[Bob Peterson <rpeterso@redhat.com>]

----- Original Message -----
| On Thu 22-06-17 15:31:08, Jan Kara wrote:
| > When new directory 'DIR1' is created in a directory 'DIR0' with SGID bit
| > set, DIR1 is expected to have SGID bit set (and owning group equal to
| > the owning group of 'DIR0'). However when 'DIR0' also has some default
| > ACLs that 'DIR1' inherits, setting these ACLs will result in SGID bit on
| > 'DIR1' to get cleared if user is not member of the owning group.
| > 
| > Fix the problem by moving posix_acl_update_mode() out of
| > __gfs2_set_acl() into gfs2_set_acl(). That way the function will not be
| > called when inheriting ACLs which is what we want as it prevents SGID
| > bit clearing and the mode has been properly set by posix_acl_create()
| > anyway.
| > 
| > Fixes: 073931017b49d9458aa351605b43a7e34598caef
| > CC: stable@vger.kernel.org
| > CC: cluster-devel@redhat.com
| > CC: Bob Peterson <rpeterso@redhat.com>
| > Signed-off-by: Jan Kara <jack@suse.cz>
| 
| Bob, can you please pick up this fix? Thanks!

Hi Honza,

Sorry this slipped my attention for so long.
This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=914cea93dd89f00b41c1d8ff93f17be47356a36a

Regards,

Bob Peterson
Red Hat File Systems