From: Valdis.Kletnieks@vt.edu
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Jeremy Kerr <jk@ozlabs.org>,
"John W. Linville" <linville@tuxdriver.com>,
Julia Lawall <julia@diku.dk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-omap@vger.kernel.org,
linuxppc-dev@ozlabs.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, Samuel Ortiz <samuel@sortiz.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 00/15] change default_llseek action
Date: Wed, 15 Sep 2010 11:38:56 -0400 [thread overview]
Message-ID: <9828.1284565136@localhost> (raw)
In-Reply-To: Your message of "Tue, 14 Sep 2010 22:22:28 +0200." <1284495763-7506-1-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Tue, 14 Sep 2010 22:22:28 +0200, Arnd Bergmann said:
> This changes *all* instances of struct file_operations in
> the kernel to have a .llseek operation and then changes
> the default to no_llseek, which returns -ESPIPE, which
> is what we had decided some time ago in a discussion
> with Christoph Hellwig.
I don't suppose there's any clean way to throw a build error or a
printk_on_once() or something if we encounter an unconverted 'struct
file_operations', is there? I have this creeping fear that this patch will go
upstream during the merge window - as will 12 new staging/ drivers from authors
who didn't get the memo yet.
Other than the "missed converting a new usage" issue, it looks OK to me.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2010-09-15 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 20:22 [PATCH 00/15] change default_llseek action Arnd Bergmann
2010-09-14 20:22 ` [PATCH 15/15] vfs: make no_llseek the default Arnd Bergmann
2010-09-15 9:39 ` [PATCH 00/15] change default_llseek action Stephen Rothwell
2010-09-15 16:06 ` Luis R. Rodriguez
2010-09-15 15:38 ` Valdis.Kletnieks [this message]
2010-09-15 16:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9828.1284565136@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=jk@ozlabs.org \
--cc=julia@diku.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=sfr@canb.auug.org.au \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).