* [PATCH] vboxsf: Directly use ida_alloc()/free()
@ 2022-06-15 6:29 Bo Liu
2022-06-15 19:20 ` Christophe JAILLET
2022-06-15 19:34 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Bo Liu @ 2022-06-15 6:29 UTC (permalink / raw)
To: hdegoede; +Cc: linux-fsdevel, linux-kernel, Bo Liu
Use ida_alloc()/ida_free() instead of
ida_simple_get()/ida_simple_remove().
The latter is deprecated and more verbose.
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
fs/vboxsf/super.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
index d2f6df69f611..24ef7ddecf89 100644
--- a/fs/vboxsf/super.c
+++ b/fs/vboxsf/super.c
@@ -155,7 +155,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
}
}
- sbi->bdi_id = ida_simple_get(&vboxsf_bdi_ida, 0, 0, GFP_KERNEL);
+ sbi->bdi_id = ida_alloc(&vboxsf_bdi_ida, GFP_KERNEL);
if (sbi->bdi_id < 0) {
err = sbi->bdi_id;
goto fail_free;
@@ -221,7 +221,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
vboxsf_unmap_folder(sbi->root);
fail_free:
if (sbi->bdi_id >= 0)
- ida_simple_remove(&vboxsf_bdi_ida, sbi->bdi_id);
+ ida_free(&vboxsf_bdi_ida, sbi->bdi_id);
if (sbi->nls)
unload_nls(sbi->nls);
idr_destroy(&sbi->ino_idr);
@@ -268,7 +268,7 @@ static void vboxsf_put_super(struct super_block *sb)
vboxsf_unmap_folder(sbi->root);
if (sbi->bdi_id >= 0)
- ida_simple_remove(&vboxsf_bdi_ida, sbi->bdi_id);
+ ida_free(&vboxsf_bdi_ida, sbi->bdi_id);
if (sbi->nls)
unload_nls(sbi->nls);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vboxsf: Directly use ida_alloc()/free()
2022-06-15 6:29 [PATCH] vboxsf: Directly use ida_alloc()/free() Bo Liu
@ 2022-06-15 19:20 ` Christophe JAILLET
2022-06-15 19:34 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-06-15 19:20 UTC (permalink / raw)
To: Bo Liu, hdegoede; +Cc: linux-fsdevel, linux-kernel
Le 15/06/2022 à 08:29, Bo Liu a écrit :
> Use ida_alloc()/ida_free() instead of
> ida_simple_get()/ida_simple_remove().
> The latter is deprecated and more verbose.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
Hi,
for what it's worth:
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> fs/vboxsf/super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
> index d2f6df69f611..24ef7ddecf89 100644
> --- a/fs/vboxsf/super.c
> +++ b/fs/vboxsf/super.c
> @@ -155,7 +155,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
> }
> }
>
> - sbi->bdi_id = ida_simple_get(&vboxsf_bdi_ida, 0, 0, GFP_KERNEL);
> + sbi->bdi_id = ida_alloc(&vboxsf_bdi_ida, GFP_KERNEL);
> if (sbi->bdi_id < 0) {
> err = sbi->bdi_id;
> goto fail_free;
> @@ -221,7 +221,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
> vboxsf_unmap_folder(sbi->root);
> fail_free:
> if (sbi->bdi_id >= 0)
> - ida_simple_remove(&vboxsf_bdi_ida, sbi->bdi_id);
> + ida_free(&vboxsf_bdi_ida, sbi->bdi_id);
> if (sbi->nls)
> unload_nls(sbi->nls);
> idr_destroy(&sbi->ino_idr);
> @@ -268,7 +268,7 @@ static void vboxsf_put_super(struct super_block *sb)
>
> vboxsf_unmap_folder(sbi->root);
> if (sbi->bdi_id >= 0)
> - ida_simple_remove(&vboxsf_bdi_ida, sbi->bdi_id);
> + ida_free(&vboxsf_bdi_ida, sbi->bdi_id);
> if (sbi->nls)
> unload_nls(sbi->nls);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vboxsf: Directly use ida_alloc()/free()
2022-06-15 6:29 [PATCH] vboxsf: Directly use ida_alloc()/free() Bo Liu
2022-06-15 19:20 ` Christophe JAILLET
@ 2022-06-15 19:34 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2022-06-15 19:34 UTC (permalink / raw)
To: Bo Liu; +Cc: linux-fsdevel, linux-kernel
Hi,
On 6/15/22 08:29, Bo Liu wrote:
> Use ida_alloc()/ida_free() instead of
> ida_simple_get()/ida_simple_remove().
> The latter is deprecated and more verbose.
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> fs/vboxsf/super.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
> index d2f6df69f611..24ef7ddecf89 100644
> --- a/fs/vboxsf/super.c
> +++ b/fs/vboxsf/super.c
> @@ -155,7 +155,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
> }
> }
>
> - sbi->bdi_id = ida_simple_get(&vboxsf_bdi_ida, 0, 0, GFP_KERNEL);
> + sbi->bdi_id = ida_alloc(&vboxsf_bdi_ida, GFP_KERNEL);
> if (sbi->bdi_id < 0) {
> err = sbi->bdi_id;
> goto fail_free;
> @@ -221,7 +221,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
> vboxsf_unmap_folder(sbi->root);
> fail_free:
> if (sbi->bdi_id >= 0)
> - ida_simple_remove(&vboxsf_bdi_ida, sbi->bdi_id);
> + ida_free(&vboxsf_bdi_ida, sbi->bdi_id);
> if (sbi->nls)
> unload_nls(sbi->nls);
> idr_destroy(&sbi->ino_idr);
> @@ -268,7 +268,7 @@ static void vboxsf_put_super(struct super_block *sb)
>
> vboxsf_unmap_folder(sbi->root);
> if (sbi->bdi_id >= 0)
> - ida_simple_remove(&vboxsf_bdi_ida, sbi->bdi_id);
> + ida_free(&vboxsf_bdi_ida, sbi->bdi_id);
> if (sbi->nls)
> unload_nls(sbi->nls);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-15 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-15 6:29 [PATCH] vboxsf: Directly use ida_alloc()/free() Bo Liu
2022-06-15 19:20 ` Christophe JAILLET
2022-06-15 19:34 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).