From: hooanon05@yahoo.co.jp
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mhalcrow@us.ibm.com, ecryptfs-devel@lists.launchpad.net
Subject: Re: [PATCH] ecryptfs: some inode attrs, and a question
Date: Fri, 16 Jan 2009 16:42:31 +0900 [thread overview]
Message-ID: <9845.1232091751@jrobl> (raw)
In-Reply-To: <20090115150332.f72ad0f8.akpm@linux-foundation.org>
Andrew Morton:
> > + atomic_inc_return(&lower_dentry->d_inode->i_count);
> > + atomic_inc_return(&lower_inode->i_count);
>
> atomic_inc() would suffice here, yes?
I thought that ..._return() is smp safe and necessary here.
Because lower_inode may be touched by lower fs (outside of ecryptfs).
Anyway my original patch seemed to be already dropped.
J. R. Okajima
next prev parent reply other threads:[~2009-01-16 7:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 6:20 [PATCH] ecryptfs: some inode attrs, and a question hooanon05
2009-01-13 13:17 ` Dave Kleikamp
2009-01-15 21:51 ` [Ecryptfs-devel] " Tyler Hicks
2009-01-16 7:36 ` hooanon05
2009-01-16 16:59 ` Dave Kleikamp
2009-01-17 6:03 ` hooanon05
2009-01-17 16:42 ` Dave Kleikamp
2009-01-17 17:42 ` hooanon05
2009-01-17 18:11 ` Dave Kleikamp
2009-01-19 2:17 ` hooanon05
2009-01-19 15:01 ` Dave Kleikamp
2009-01-19 15:25 ` hooanon05
2009-01-19 15:30 ` Dave Kleikamp
2009-01-19 15:35 ` hooanon05
2009-01-19 2:15 ` hooanon05
2009-01-16 8:04 ` hooanon05
2009-01-15 23:03 ` Andrew Morton
2009-01-15 23:39 ` [Ecryptfs-devel] " Tyler Hicks
2009-01-15 23:51 ` Andrew Morton
2009-01-16 7:42 ` hooanon05 [this message]
2009-01-16 7:53 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9845.1232091751@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=akpm@linux-foundation.org \
--cc=ecryptfs-devel@lists.launchpad.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).