From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EBDC433B4 for ; Sat, 8 May 2021 12:22:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EEBB61059 for ; Sat, 8 May 2021 12:22:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230473AbhEHMXj (ORCPT ); Sat, 8 May 2021 08:23:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43125 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230449AbhEHMXi (ORCPT ); Sat, 8 May 2021 08:23:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620476557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XqIHXF/RzgI6RicHORDy0FfhUzmOMaZdt2NO6pcWHTE=; b=COJbkSoj4j1qOHBsqPkw575AO9W+UYTDGAafdpeBYqM1CWY+nrAVgikc+s/8pVDiOLzmsC QvKHxyPouyR4Q0PhJpQejDkSVKr133QCztJlYxWhEkh+vsZTiNV28v5J3pt6x5suglO5wq 7UDMoHLov8620p7ukgrZM/RtdvCVIV8= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-132-80agrf4VO3ObdSjwTfZJoA-1; Sat, 08 May 2021 08:22:35 -0400 X-MC-Unique: 80agrf4VO3ObdSjwTfZJoA-1 Received: by mail-oi1-f198.google.com with SMTP id x6-20020acae0060000b02901e5030d8682so6116028oig.19 for ; Sat, 08 May 2021 05:22:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XqIHXF/RzgI6RicHORDy0FfhUzmOMaZdt2NO6pcWHTE=; b=RbpYES/KQvmcsT2tCIUQtiabMVfSBya7SAhNbKIC1oj645u8huJy1RSPoBVuytnYzi TDlt83KQiPkTJRNCbKQQm9ivT9GAEc37BSB1kSQAhY3kPrOg8EWmliaIULuoF5VP5TB2 0qrtBjX+NiHVPytCrJsDpDSviK6SYtr77CSnpjrECTNdm42MXdu/59syB7yWcJ7G1K6R 5SN/FbQNF9QJaIlpOcNYFvTkw01wqRjCF28tmAuy1rP+/5i9CwVMoKliZGka4oT4dgid rWveyb6x3S9Sukgod7RQZ1FNwQ1dmUmz0XXECkfLXvW6tiB+iDOhSqJfvn++iP44BpH2 /zdw== X-Gm-Message-State: AOAM5330YoEMtM4s3/afw3EkLDSkH2l4xCLDY07VdfDh/4qOf4wv0ETS W2aKASbGnfuSv1+b+cA1furQZk0Hs5Pl/DVMrxAFj6XVYzYOeERDGgFXjkzOh2tNCNY3r74s/bF XilcW9KCNT9qEHcptD8chcEG00Q== X-Received: by 2002:aca:c402:: with SMTP id u2mr11001586oif.139.1620476554665; Sat, 08 May 2021 05:22:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCaPhvMNHUP48XCcuNXFvnwBEM6JmWvAjl7sIYqItYIsYwDPp1DaYba66prqr9etqJ/4m3QQ== X-Received: by 2002:aca:c402:: with SMTP id u2mr11001579oif.139.1620476554493; Sat, 08 May 2021 05:22:34 -0700 (PDT) Received: from [192.168.0.112] (ip68-103-222-6.ks.ok.cox.net. [68.103.222.6]) by smtp.gmail.com with ESMTPSA id z4sm1744288otq.65.2021.05.08.05.22.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 May 2021 05:22:34 -0700 (PDT) Subject: Re: [PATCH] virtiofs: Enable multiple request queues From: Connor Kuehl To: virtio-fs@redhat.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, Miklos Szeredi , Stefan Hajnoczi , Vivek Goyal References: <20210507221527.699516-1-ckuehl@redhat.com> Message-ID: <9b9c8779-84b4-5c6d-8dc2-c16f18c68c70@redhat.com> Date: Sat, 8 May 2021 07:22:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210507221527.699516-1-ckuehl@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 5/7/21 5:15 PM, Connor Kuehl wrote: > Distribute requests across the multiqueue complex automatically based > on the IRQ affinity. > > Suggested-by: Stefan Hajnoczi > Signed-off-by: Connor Kuehl > --- > fs/fuse/virtio_fs.c | 30 ++++++++++++++++++++++++------ > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c > index bcb8a02e2d8b..dcdc8b7b1ad5 100644 > --- a/fs/fuse/virtio_fs.c > +++ b/fs/fuse/virtio_fs.c > @@ -30,6 +30,10 @@ > static DEFINE_MUTEX(virtio_fs_mutex); > static LIST_HEAD(virtio_fs_instances); > > +struct virtio_fs_vq; > + > +DEFINE_PER_CPU(struct virtio_fs_vq *, this_cpu_fsvq); > [..] > + > + for_each_cpu(cpu, mask) { > + struct virtio_fs_vq **cpu_vq = per_cpu_ptr(&this_cpu_fsvq, cpu); > + *cpu_vq = &fs->vqs[i]; > + } > + } Hmm, actually, it's just occurred to me that the per-CPU state could be problematic with multiple virtio-fs mounts. I'll workshop this some more. Connor