From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kyungmin Park" <kmpark@infradead.org>
Subject: Re: [patch 5/15] fs/logfs/dir.c
Date: Fri, 4 Apr 2008 15:22:20 +0900
Message-ID: <9c9fda240804032322x7316ff78lee646d22cb66178a@mail.gmail.com>
References: <20080401181308.512473173@logfs.org>
	 <20080401181332.853833005@logfs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mtd@lists.infradead.org
To: joern@logfs.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from yw-out-2324.google.com ([74.125.46.28]:55683 "EHLO
	yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752169AbYDDGW3 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 4 Apr 2008 02:22:29 -0400
Received: by yw-out-2324.google.com with SMTP id 5so504491ywb.1
        for <linux-fsdevel@vger.kernel.org>; Thu, 03 Apr 2008 23:22:28 -0700 (PDT)
In-Reply-To: <20080401181332.853833005@logfs.org>
Content-Disposition: inline
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi,

It's just quick view
>  +
>  +static int logfs_lookup_handler(struct inode *dir, struct dentry *dentry,
>  +               struct logfs_disk_dentry *dd, loff_t pos, void *arg)
>  +{
>  +       struct inode *inode;
>  +
>  +       inode = iget(dir->i_sb, be64_to_cpu(dd->ino));
>  +       if (!inode)
>  +               return -EIO;
>  +       return PTR_ERR(d_splice_alias(inode, dentry));
>  +}
>  +

The latest kernel doesn't have iget anymore. I saw some files use the
logfs_iget but dir.c, readwrite.c, ... uses the iget directly.
Please update this one.

Thank you,
Kyungmin Park