From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org,
Carlos Maiolino <cmaiolino@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: move guard_bio_eod() after bio_set_op_attrs
Date: Sun, 5 Jan 2020 17:45:57 -0700 [thread overview]
Message-ID: <9d6e90cc-f75b-de72-6865-c392ab6161c7@kernel.dk> (raw)
In-Reply-To: <20200105014114.4824-1-ming.lei@redhat.com>
On 1/4/20 6:41 PM, Ming Lei wrote:
> Commit 85a8ce62c2ea ("block: add bio_truncate to fix guard_bio_eod")
> adds bio_truncate() for handling bio EOD. However, bio_truncate()
> doesn't use the passed 'op' parameter from guard_bio_eod's callers.
>
> So bio_trunacate() may retrieve wrong 'op', and zering pages may
> not be done for READ bio.
>
> Fixes this issue by moving guard_bio_eod() after bio_set_op_attrs()
> in submit_bh_wbc() so that bio_truncate() can always retrieve correct
> op info.
>
> Meantime remove the 'op' parameter from guard_bio_eod() because it isn't
> used any more.
I'll queue this up, since the previous fix went through the block tree.
--
Jens Axboe
prev parent reply other threads:[~2020-01-06 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 1:41 [PATCH] fs: move guard_bio_eod() after bio_set_op_attrs Ming Lei
2020-01-06 0:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d6e90cc-f75b-de72-6865-c392ab6161c7@kernel.dk \
--to=axboe@kernel.dk \
--cc=cmaiolino@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).