From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f193.google.com ([209.85.220.193]:46921 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753171AbeFINoE (ORCPT ); Sat, 9 Jun 2018 09:44:04 -0400 Received: by mail-qk0-f193.google.com with SMTP id k86-v6so10472221qkh.13 for ; Sat, 09 Jun 2018 06:44:03 -0700 (PDT) Message-ID: <9e3ad8b27b199384e11e64e09b5ea493a744dd4c.camel@redhat.com> Subject: Re: [PATCH] removed extra extern file_fdatawait_range From: Jeff Layton To: Vasily Averin , Alexander Viro Cc: linux-fsdevel@vger.kernel.org Date: Sat, 09 Jun 2018 09:44:01 -0400 In-Reply-To: <6524c785-163b-e416-a587-37f5ad31cdb8@virtuozzo.com> References: <6524c785-163b-e416-a587-37f5ad31cdb8@virtuozzo.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, 2018-06-09 at 16:18 +0300, Vasily Averin wrote: > Jeff added this extern twice in commit a823e4589e68 > > Fixes: a823e4589e68 ("mm: add file_fdatawait_range and file_write_and_wait") > Signed-off-by: Vasily Averin > --- > include/linux/fs.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 760d8da..2e98d80 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -2602,8 +2602,6 @@ static inline int filemap_fdatawait(struct address_space *mapping) > > extern bool filemap_range_has_page(struct address_space *, loff_t lstart, > loff_t lend); > -extern int __must_check file_fdatawait_range(struct file *file, loff_t lstart, > - loff_t lend); > extern int filemap_write_and_wait(struct address_space *mapping); > extern int filemap_write_and_wait_range(struct address_space *mapping, > loff_t lstart, loff_t lend); Doh! Good catch. Reviewed-by: Jeff Layton