Re: [PATCH v4 2/6] NFSD: Add NFSD_CMD_UNLOCK netlink command with ip scope

[Chuck Lever <cel@kernel.org>]

On 3/18/26 10:28 AM, Jeff Layton wrote:
> On Wed, 2026-03-18 at 10:15 -0400, Chuck Lever wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>

>> @@ -227,3 +249,13 @@ operations:
>>            attributes:
>>              - mode
>>              - npools
>> +    -
>> +      name: unlock
>> +      doc: release NLM locks by scope
>> +      attribute-set: unlock
>> +      flags: [admin-perm]
>> +      do:
>> +        request:
>> +          attributes:
>> +            - type
>> +            - address
> 
> I wonder if we'd be better served with different commands instead of
> passing a type value to a single command? Different types are going to
> require different attributes, and it'll be easier to validate those if
> they use different commands.

I was following your philosophy about the THREADS command. But it's
correct that the YAML/netlink infrastructure struggles a bit when the
arguments for each of the subcommands are so different from each other.
I don't think it would be difficult to break UNLOCK into three separate
unlock netlink commands.


-- 
Chuck Lever