From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 471C22581; Mon, 23 Jun 2025 14:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.80 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750688640; cv=fail; b=No0c1oz3VUWT+JCsaFklMcGsFkuq1EM3mI+lHbhyBxFxTRSoeq++1kVK4a2L3odXoKlHZY8tHAxFj77rF1Xi05w5gp5dI0a+kiYK99Ngp8EfKS0htZBpLAdWEPjjbonBo5EWGzxRfKDXvzEUSg1Ky9Y6YgDGkbW5n6m1/xI3Chg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750688640; c=relaxed/simple; bh=gwX4HLxraU/bZXL1v10LTwblZx740eAC7t/LitB2Uas=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=YpuhYyrG9jGRcqryymTmo3ssePLG1gLw8wGeKI4FcQ72vqBlNJxypJubyBGuwyDv/XTJlTCUbbWCD0R7wbVg6T2+evgWSLoGc4mAlLSLbUydiBscSP6kvxIa9DjGweArcPaVRtbJ/ZLU7tRrPIfOl6xKPeJkt2JdtWOobHNsO0Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lLNwhTn+; arc=fail smtp.client-ip=40.107.244.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lLNwhTn+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kujUF7Nn2QdDX+1BZKctW+wGxQkZFEvEzLZXFGs9fTxyH8AIsxnz5ETfud7aZ11TU4liegMl2VuDaIdRlXqHLQZEuKCulwc0rMYMaSv2Kog7XQgFe7/jBgKbvAWoYdYOLeU4VYCwhE2SNglx1cRm7dctWP7hYPlT3AXk0xLVxXjEdSNRq9LT7QSawbW9tjDAzRvoXlGk1f0cJtd06d/pRUa0IjmGHx69E0X5VIvbCh2D9FsR8Op1kBPRGvjFHHsvEtWa5KrtnxB/1Au/KEs5NDdhaAZrgtH5qI/YKNwU8OHgzRzkQe8OUkLKVDBIoovJcWMrkrbTLh8d3VYrYz+Rpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8p0eZyi8SY0IETtpjRnmIZRmC0o6uV6Sz6V7BnjQZ00=; b=owbyRyPxvk77RuNASItLnjUl4+kG+i/CPx7W/Tp1NfS8dsP3wLkUNsp1f+6RyMT/I1unq4CzXotpFfNtseR4VNkKzCNLsWhTrbTkqDha0WyQyvsHey4gqwpDeg/eTxyoPs4AZZ8E6TJ5VpQSgTBIy9nOXn0vdlfA2QCoLQeQLRVd+NUOINvd63eYzX9Bo6lKfpcvd8ZE1X5beIqARtKqESOjxCWutX14wsI3SixitmUpXsJeb6ZsKh66DALDauFai0sneD2cIknV6CHpsnXN7VtfJ/B/o2D/XRJG1JaeIGv/P2znL6I/gbh+J8qGoMEz9cr65YBtmHQeO3a9FUR08Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8p0eZyi8SY0IETtpjRnmIZRmC0o6uV6Sz6V7BnjQZ00=; b=lLNwhTn+Zi0CRcfyVEAJk5XyAkZj7rlMJsMKTtEqL5VWGe2hBQ7PnWwl+yBwEccZWcbPi1qQNJIy6jhs2WizUyYIWXiZ2f5g3V98bx+NDUynr6Hd3RG+f7J99QcuJH0MM83hYRqzffsAMGGmuNSxT8ABnn8SNkRIz7Aqs/4PIiURBDBLrubf3R+cAzp8FNH12qWpXTRrqqzCDgBdL+BtnQ0xR7H7HxTqjXK8diX4fmQoW+7gQj9UaWkX2gs+f+sAe5hhLT6rOUI2NY2tYaba//wEzpfcOdhIxAIPIruk97/xcAY/7Ks5RQMH1hyTc3u27w7yE29EH/Ov/LVGbWGDfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV8PR12MB9358.namprd12.prod.outlook.com (2603:10b6:408:201::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.28; Mon, 23 Jun 2025 14:23:53 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8835.037; Mon, 23 Jun 2025 14:23:53 +0000 From: Zi Yan To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH RFC 25/29] mm: simplify folio_expected_ref_count() Date: Mon, 23 Jun 2025 10:23:49 -0400 X-Mailer: MailMate (2.0r6265) Message-ID: In-Reply-To: <20250618174014.1168640-26-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-26-david@redhat.com> Content-Type: text/plain X-ClientProxiedBy: BN9PR03CA0848.namprd03.prod.outlook.com (2603:10b6:408:13d::13) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV8PR12MB9358:EE_ X-MS-Office365-Filtering-Correlation-Id: 54185383-7a2c-4cb1-4a0d-08ddb2619473 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5yIHzlpzywQVzsIJty5GPZ5ARyrwsbBIlFtP6B35bWN8cs6c0T9oDZHb5g3p?= =?us-ascii?Q?GhmpMg11tfvZrQjpIXs/Bj3T/XtTqKjD2GyvJv/9nexfDF/Fsg8t1WqwdTBI?= =?us-ascii?Q?PbMSnpYS55BKt5qMS7LfErfRXoVr8ygmdN8wk82SChJ54eJBoCkMr9eXsUrC?= =?us-ascii?Q?1+vg054YykhvtcMXNINHmomNyS86GhoP06iHa7GhyULKSEx9Ou/Vqq/5L0Jk?= =?us-ascii?Q?PXRJlkdv6xt7UYlKTG4MPFc0zZucTwL0ygpdeNYeyEv5aXSOA0sTI7rVOCTf?= =?us-ascii?Q?TVfOH9zBuubsGa+shu2qxMGDj9S3I+Iyg1fobvpY6kR+1FLKTQA8WW7Y97Hh?= =?us-ascii?Q?8iV4CB8bSgvgGbFO6smhu5ssidwqWUHXgNua+20IdfgcsUaBpwe5ruuD5UaG?= =?us-ascii?Q?tU3eBB9m7PPKQZo57bTupmiLCJgZoFb3Y+NBpgXvbp9Z+CY28gNp5YsKAlM5?= =?us-ascii?Q?HcTU+iSAWJQEyGP3mvSJhYQSuqcgV2LzKdJJyc/PGl6uORJGMHi2DGIyh7ME?= =?us-ascii?Q?Uimx7XPGe+dCUYFf3PYv3nrp2lv4hzfqTiMSPYxQTZuHcUk+0ROOfSwEE0AB?= =?us-ascii?Q?EF44vPi+jlZ1Zc8rC910ZwYS9F1FfZfK8z1oSqz6imwBUiu21Q7jm5Qryc95?= =?us-ascii?Q?IE2YhALau8yFdd74hudHmcwca6/8ZnYpTNMf3IKJE2pX3R3/667apuccWlyL?= =?us-ascii?Q?glI+ILvm8/99LXDHAYiwWPS/N3puHTON/BAa7/HnECPMjhj73KuWhK2Yfa+H?= =?us-ascii?Q?Ydfy9UCeoQeeFlxicO0y3e8IncOvqqPrXj0LLRNhPftu9NzLabqq+YSWEPNg?= =?us-ascii?Q?LdLfRLAfVPdsYimTtYsBOD3ZV9N6UJ5Tuvgy3AWba6wLgMgZWhO7zziSn8Cu?= =?us-ascii?Q?xHBg3AAi68F2WRxBfv5JLmGyjzgvVuSnzbRPFCxXuhdWD2zV7zY/wJsv3cDq?= =?us-ascii?Q?j8XoKTbelwRJlALpoaGMYSuBo53E6xKbVSss+pTyyUtZMLd0chfyIqCw/DUS?= =?us-ascii?Q?kBDYyUx0cim5NILO0Z80lg5SklsQ2s6osj8VzFKYKrIBTORQBQf+WVbIrJK2?= =?us-ascii?Q?8hWCIoQGAfH8tKr2DS89+CNayk8HATQyZ9O+t5oe1Y3uQCMqDFDmt0MsOq26?= =?us-ascii?Q?13B6jm3BHd0ywBwX34Pu+b8+vL3RD+M7tICdp6DnkOSiDx7HFViQIhLdXcb3?= =?us-ascii?Q?LtLYH9l5VjHYMZNU7cyafRMt9UkOKkRDLJ4JrEfTI6Yl1s8fIBo7A9CzugBk?= =?us-ascii?Q?9DY7GmVRETCuemkp67d4nwU/iyksWlY3jrx0rVlLYw+KWsG+Vwyv3V0ny83E?= =?us-ascii?Q?7NND9RoyVUB5/VIIxb8ySDmiRpSLF48XE0GngxQbqhHhDyCgCDgWTd8hgv9+?= =?us-ascii?Q?NoZOp5DvwuVFhpbTrJgkBXMUIA84KyZKGJn32CcCIAU+5HzXsw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PAJDZB6KwSh4r9BkdDY2QkVLuPl7PAFAb+71ik4cgV6J4+jDVnPX5+uyS3J4?= =?us-ascii?Q?oQLmRDsAP52L3ZXAa5+vD5R9BQjZFdf4P9QKNr6/AyjL2TNbfQXlpLuujDu1?= =?us-ascii?Q?zDuzUeZmBY9eXL0fFSP2/jyScWH4aEz/xq9km0Qe8+mGgOkIZzXAUk+ORbNM?= =?us-ascii?Q?jXRh91aDz6KexApH/02x2LZrqMJi597oXm2h76vG6u4Px8IM+XTyQumHhak+?= =?us-ascii?Q?zBJXrrpz3iUnPxNM+/PqQtXo41xDgMegxgNP/d8y0X2j5+ZUqH8kO3/JYsCA?= =?us-ascii?Q?XRgFMUQGs1v5+OYHEXKtZE06eO2QK5TVxghtTj2nsLQzcYSnVuFSFgdNSekd?= =?us-ascii?Q?9/LqSX/eGGr4p2pyHSsPvb6UUlVTsaR+CSKB6pUYK7IWjujhP4yHJfn/aonQ?= =?us-ascii?Q?Wwr7vuH5mQODDrLMhrE3QBcSSf7eCk1jxnOKHTr2ROLUa+P6ijUfvg0UMT+z?= =?us-ascii?Q?C+a/uyxXjnN/1jSShGQ1mhLP3c6dP5kVIiHctTXNoAQPI3VHucwy1Nx7kPN2?= =?us-ascii?Q?+WdMyefKinzbupu2UW4oyGn1EIiv8re52FpsvKvIw7QpQyySrqMYmAhq3c5D?= =?us-ascii?Q?OBAkbDuFLxPjbG+uTVzdp9kfIn74PLaDu3QoSajMZVEPiylDRmeYVFUT9aSK?= =?us-ascii?Q?lp+zcT8XNlr+ezJG4J+pCjkRwitufRwVwqQa8KdMQXfoX8CeVmkH8K8qUlrw?= =?us-ascii?Q?Na32/1ZuCf/VebBcwwyxY6n6TPFRVqK9MknLpjhGsCg5uh9TtdjjrD25uWKr?= =?us-ascii?Q?n489HyhqdQg3uNa7LDdpU/nuQ+/5DSzS+MOPlj+TSLn23xaJkIFwXcMuDHDB?= =?us-ascii?Q?d2v3jfU0KUk1FQh/Lx5sfN9ZAjHRrte2KX4gYZhXLITGI//ZJfjEirGr+kgG?= =?us-ascii?Q?EpQxIYrThS+D43cu38AxTEoK6K2+AQfM5Ts2zt0K7FJizWICcWSD2jeiw2b/?= =?us-ascii?Q?xMvplESQEKy5mZx5gBJ6lhEd05w6ZwnyGEgKk7rmpShDyxxbRhp/e8tDouHY?= =?us-ascii?Q?EWqB9rIbz6pFDVp36C8S902Wax8JR2vEndrioStOj4uCsm2Ts/jPKZJ43tfd?= =?us-ascii?Q?30xSc77M92XcbvYRVBCNfBV1OzsCr5EO4UxlEJxG7dFWwsVajwzrGHy9IfrO?= =?us-ascii?Q?mcWKan93Bvd24BQFlpejhZHhGLegetD4HaJASDEvaQ2wDItw5XTpLPh56Qjk?= =?us-ascii?Q?7wJe4F8xvGK4qlYl43CmXy8fsn0vUf3CXXp3w8ENFib9ITWHubaaw9Hw5+yJ?= =?us-ascii?Q?ZKhandlunME/TP1xeJfRPrYUPCiugWywEaPpY2/2HL2QLgbGCCFW1tAAtOBk?= =?us-ascii?Q?VdDCO9cNFSk7uEPElqoNGkOMF38Z3tLFyYDMsHoRSpxkKZMRHavBlp2eay2M?= =?us-ascii?Q?0/I3wuPws9RmC+4HXghFdH96h/OSZG6hrivYyOY8DVEfUDAViM6oFUxKZTIN?= =?us-ascii?Q?5aUFLnya4n9wgVGE9i0ZCkWhFlDdokOwyi/rYEfrG9BkP73gezvOtyCaw2Pj?= =?us-ascii?Q?hHaJOj1L/zHraQlhQbpXdRPRtaTewVskv2VpqyFSeHM7F/MQpILax0Pr64dJ?= =?us-ascii?Q?QNOB5z5Qfvh0nr9Ygo8wbQK7TvlUxDKULeuZPHoK?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54185383-7a2c-4cb1-4a0d-08ddb2619473 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2025 14:23:53.1155 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VaIGel2GAbRZPRw8f0SMVHsNIdIJfoApKlrSMLVUY2m4AbVdUesdPBpFEGWnt0vs X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9358 On 18 Jun 2025, at 13:40, David Hildenbrand wrote: > Now that PAGE_MAPPING_MOVABLE is gone, we can simplify and rely on the > folio_test_anon() test only. > > ... but staring at the users, this function should never even have been > called on movable_ops pages. E.g., > * __buffer_migrate_folio() does not make sense for them > * folio_migrate_mapping() does not make sense for them > * migrate_huge_page_move_mapping() does not make sense for them > * __migrate_folio() does not make sense for them > * ... and khugepaged should never stumble over them > > Let's simply refuse typed pages (which includes slab) except hugetlb, > and WARN. > > Signed-off-by: David Hildenbrand > --- > include/linux/mm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Zi Yan -- Best Regards, Yan, Zi