From: Steven Liu <lingjiujianke@gmail.com>
To: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
randy.dunlap@oracle.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
dchinner@redhat.com, liuqi <liuqi@thunderst.com>
Subject: [PATCH] code cleanup on fs/super.c
Date: Thu, 17 Feb 2011 16:59:02 +0800 [thread overview]
Message-ID: <AANLkTi=50m7xULN+Mob1942b+qBEgMcqUPDWSd3inan6@mail.gmail.com> (raw)
Hi All,
Can this patch be fixed?
Clean up the unsed code on fs/super.c, all filesystem using mount_bdev
and mount_nodev to replace get_sb_bdev and get_sb_nodev.
Signed-off-by: LiuQi <lingjiujianke@gmail.com>
---
fs/super.c | 31 -------------------------------
1 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 7e9dd4c..8272f26 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -843,22 +843,6 @@ error:
}
EXPORT_SYMBOL(mount_bdev);
-int get_sb_bdev(struct file_system_type *fs_type,
- int flags, const char *dev_name, void *data,
- int (*fill_super)(struct super_block *, void *, int),
- struct vfsmount *mnt)
-{
- struct dentry *root;
-
- root = mount_bdev(fs_type, flags, dev_name, data, fill_super);
- if (IS_ERR(root))
- return PTR_ERR(root);
- mnt->mnt_root = root;
- mnt->mnt_sb = root->d_sb;
- return 0;
-}
-
-EXPORT_SYMBOL(get_sb_bdev);
void kill_block_super(struct super_block *sb)
{
@@ -897,21 +881,6 @@ struct dentry *mount_nodev(struct
file_system_type *fs_type,
}
EXPORT_SYMBOL(mount_nodev);
-int get_sb_nodev(struct file_system_type *fs_type,
- int flags, void *data,
- int (*fill_super)(struct super_block *, void *, int),
- struct vfsmount *mnt)
-{
- struct dentry *root;
-
- root = mount_nodev(fs_type, flags, data, fill_super);
- if (IS_ERR(root))
- return PTR_ERR(root);
- mnt->mnt_root = root;
- mnt->mnt_sb = root->d_sb;
- return 0;
-}
-EXPORT_SYMBOL(get_sb_nodev);
static int compare_single(struct super_block *s, void *p)
{
--
1.6.5.2
Best Regards
Steven Liu
next reply other threads:[~2011-02-17 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 8:59 Steven Liu [this message]
2011-02-17 16:20 ` [PATCH] code cleanup on fs/super.c Linus Torvalds
2011-02-17 17:25 ` Ted Ts'o
2011-02-17 17:36 ` Al Viro
2011-02-18 2:45 ` Steven Liu
2011-02-18 3:08 ` Al Viro
2011-03-21 4:00 ` LiuQi
2011-03-21 4:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=50m7xULN+Mob1942b+qBEgMcqUPDWSd3inan6@mail.gmail.com' \
--to=lingjiujianke@gmail.com \
--cc=dchinner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuqi@thunderst.com \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).