From: Marco Stornelli <marco.stornelli@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: viro@zeniv.linux.org.uk,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3][RESEND] Check for immutable/append flag in fallocate path
Date: Thu, 10 Mar 2011 13:03:08 +0100 [thread overview]
Message-ID: <AANLkTi=S++FwLwaedKE17NRFqh5B7b1MYg9OD55XRVfd@mail.gmail.com> (raw)
In-Reply-To: <20110309212735.GB27747@suse.de>
2011/3/9 Greg KH <gregkh@suse.de>:
> On Wed, Mar 09, 2011 at 08:42:25PM +0100, Marco Stornelli wrote:
>> Il 05/03/2011 11:10, Marco Stornelli ha scritto:
>> > From: Marco Stornelli <marco.stornelli@gmail.com>
>> >
>> > In the fallocate path the kernel doesn't check for the immutable/append
>> > flag. It's possible to have a race condition in this scenario: an
>> > application open a file in read/write and it does something, meanwhile
>> > root set the immutable flag on the file, the application at that point
>> > can call fallocate with success. In addition, we don't allow to do any
>> > unreserve operation on an append only file but only the reserve one.
>> >
>> > Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
>>
>> Al, can you apply this patch please? I add Greg in cc, because maybe he
>> could be interested about stable tree.
>
> Please read Documentation/stable_kernel_rules.txt for how to get patches
> into stable kernel releases (hint, emailing me like this is not the way
> to do it...)
>
I'm sorry. It wasn't a request about the add of this patch to the
stable tree, it was only a request for comment about the applicability
of this patch in the stable tree. However thanks for the tip, in case
I'll send the patch to the stable mailing list.
Regards,
Marco
next prev parent reply other threads:[~2011-03-10 12:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 8:26 [PATCH] Check for immutable flag in fallocate path Marco Stornelli
2011-02-21 12:46 ` Christoph Hellwig
2011-02-21 16:50 ` Marco Stornelli
2011-02-27 22:49 ` Ted Ts'o
2011-02-28 7:53 ` Marco Stornelli
2011-03-02 8:19 ` Marco Stornelli
2011-02-26 14:59 ` Marco Stornelli
2011-03-03 8:42 ` [PATCH v2] " Marco Stornelli
2011-03-03 21:39 ` Dave Chinner
2011-03-04 8:17 ` Marco Stornelli
2011-03-04 12:18 ` Marco Stornelli
2011-03-14 10:24 ` Christoph Hellwig
2011-03-14 10:40 ` Marco Stornelli
2011-03-05 9:37 ` [PATCH v3] Check for immutable/append " Marco Stornelli
2011-03-05 10:00 ` Sedat Dilek
2011-03-05 10:10 ` [PATCH v3][RESEND] " Marco Stornelli
2011-03-09 19:42 ` Marco Stornelli
2011-03-09 21:27 ` Greg KH
2011-03-10 12:03 ` Marco Stornelli [this message]
2011-03-08 5:11 ` [PATCH v3] " Dave Chinner
2011-03-08 5:38 ` Andreas Dilger
2011-03-08 7:35 ` Marco Stornelli
2011-03-09 1:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=S++FwLwaedKE17NRFqh5B7b1MYg9OD55XRVfd@mail.gmail.com' \
--to=marco.stornelli@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).