From: Sedat Dilek <sedat.dilek@googlemail.com>
To: Nick Piggin <npiggin@kernel.dk>
Cc: systemd-devel@lists.freedesktop.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
eparis@redhat.com
Subject: Re: [patch] cgroup fs: avoid switching ->d_op on live dentry
Date: Tue, 21 Dec 2010 16:12:03 +0100 [thread overview]
Message-ID: <AANLkTik3y9AH3_=8VeW2vLsbEB_P8tw-Qxc+AkCJp4ck@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinod+7fDMwh8_XsQe4mnF1P6WoRWyh36yJXM4LO@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]
On Tue, Dec 21, 2010 at 9:44 AM, Sedat Dilek <sedat.dilek@googlemail.com> wrote:
> Against linux-next (next-20101210) it should look like:
>
> $ diff -Naur cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
> cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
> --- cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
> 2010-12-21 09:31:38.649601964 +0100
> +++ cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
> 2010-12-21 09:40:21.151033232 +0100
> @@ -83,7 +83,7 @@
> inode->i_size = 0;
> inode->i_fop = &cgroup_file_operations;
> }
> -- dentry->d_op = &cgroup_dops;
> +- d_set_d_op(dentry, &cgroup_dops);
> d_instantiate(dentry, inode);
> dget(dentry); /* Extra count - pin the dentry in core */
> return 0;
>
> - Sedat -
>
YAY!!!
# dmesg | grep systemd
[ 0.000000] Kernel command line:
BOOT_IMAGE=/boot/vmlinuz-2.6.37-rc6-686
root=UUID=1ceb69a7-ecf4-47e9-a231-b74e0f0a9b62 ro ini
[ 4.124563] systemd[1]: systemd 15 running in system mode. (+PAM
-LIBWRAP -AUDIT +SELINUX +SYSVINIT -LIBCRYPTSETUP; debian)
[ 4.246090] systemd[1]: Set hostname to <tbox>.
[ 6.942949] systemd-logger[290]: Got error on stream: No such
process
[ 9.011378] systemd-fsck[524]: /dev/sda3: sauber, 128062/640848
Dateien, 1839774/2560359 Blöcke
[ 15.186112] systemd[1]: ifupdown-clean.service: control process
exited, code=exited status=209
[ 15.186941] systemd[1]: Unit ifupdown-clean.service entered failed state.
[ 15.187363] systemd[1]: mountoverflowtmp.service: control process
exited, code=exited status=209
[ 15.206223] systemd[1]: Unit mountoverflowtmp.service entered failed state.
[ 15.215739] systemd[1]: resolvconf.service: control process exited,
code=exited status=209
[ 15.235257] systemd[1]: Unit resolvconf.service entered failed state.
Feel free to add:
Reported-and-tested-by: Sedat Dilek <sedat.dilek@gmail.com>
(Tested with the above v2 patch against linux-next (next-20101221) -
see file attachment).
- Sedat -
[-- Attachment #2: cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch --]
[-- Type: plain/text, Size: 3277 bytes --]
next prev parent reply other threads:[~2010-12-21 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 8:44 [patch] cgroup fs: avoid switching ->d_op on live dentry Sedat Dilek
2010-12-21 8:55 ` Nick Piggin
2010-12-21 13:35 ` Sedat Dilek
2010-12-21 18:25 ` Al Viro
2010-12-21 18:57 ` Sedat Dilek
2010-12-22 3:11 ` Nick Piggin
2010-12-22 3:31 ` Sedat Dilek
2010-12-22 4:38 ` Sedat Dilek
2010-12-21 15:12 ` Sedat Dilek [this message]
2010-12-21 15:28 ` Sedat Dilek
2010-12-21 17:56 ` Sedat Dilek
-- strict thread matches above, loose matches on Subject: below --
2010-12-21 7:12 Nick Piggin
2010-12-21 9:04 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik3y9AH3_=8VeW2vLsbEB_P8tw-Qxc+AkCJp4ck@mail.gmail.com' \
--to=sedat.dilek@googlemail.com \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=sedat.dilek@gmail.com \
--cc=systemd-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).