From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sedat Dilek Subject: Re: vfs-scale, nd->inode after __do_follow_link() Date: Fri, 14 Jan 2011 10:17:25 +0100 Message-ID: References: <7352.1294971049@jrobl> <20110114052813.GZ19804@ZenIV.linux.org.uk> Reply-To: sedat.dilek@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Al Viro , "J. R. Okajima" , linux-fsdevel , linux-kernel@vger.kernel.org, webmaster@kernel.org To: Nick Piggin , patchwork@lists.ozlabs.org Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:57631 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753614Ab1ANJR2 convert rfc822-to-8bit (ORCPT ); Fri, 14 Jan 2011 04:17:28 -0500 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 14, 2011 at 9:40 AM, Nick Piggin wrote: > On Fri, Jan 14, 2011 at 4:28 PM, Al Viro wr= ote: >> On Fri, Jan 14, 2011 at 03:09:10PM +1100, Nick Piggin wrote: >> >>> > + ? ? ? ? ? ? ? ? ? ? ? struct dentry *i =3D path.dentry->d_inode= ; >>> > + ? ? ? ? ? ? ? ? ? ? ? if (!IS_ERR(cookie) && i->i_op->put_link) >>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? i->i_op->put_link(path.dentry, &n= d, cookie); >>> > ? ? ? ? ? ? ? ? ? ? ? ?/* nd.path had been dropped */ >>> > ? ? ? ? ? ? ? ? ? ? ? ?nd.path =3D path; >>> > ? ? ? ? ? ? ? ? ? ? ? ?goto out_path; >>> >>> It should be the inode we followed, rather than the inode of the >>> new path, I think. >> >> And that's what the first argument of __do_follow_link() is. =C2=A0I= 'm actually >> tempted to rename it from path to symlink and make it const to clari= fy >> the things a bit. > > Yes I was completely wrong there, thanks again for another good > catch. I'll merge this in the vfs-scale branch, and ask to merge if > there are no objections. > [ CCing patchwork ML ] Can you send your patch separately, please? Within a (long) thread it is eaten up. As *.patch are somehow not presented as diff (see [1]), someone can't catch them from . =46urthermore, it would be very cool to see linux-fsdevel (patches from its ML) in . I don't know whom to contact from the linux-fsdevel ML, sorry for this. - Sedat - [1] http://lkml.org/lkml/2011/1/14/55 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html