From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Van Hensbergen Subject: Re: [V9fs-developer] [RFC PATCH -V2 06/17] fs/9p: Add fid to inode in cached mode Date: Mon, 7 Feb 2011 09:30:22 -0600 Message-ID: References: <1296928005-9529-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1296928005-9529-7-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:48506 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753649Ab1BGPak (ORCPT ); Mon, 7 Feb 2011 10:30:40 -0500 In-Reply-To: <1296928005-9529-7-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Feb 5, 2011 at 11:46 AM, Aneesh Kumar K.V wrote: > The fid attached to inode will be opened O_RDWR mode and is used > for dirty page writeback only. > > FIXME!!: Should we make the fid owned by uid = 0 > Good question, the idea was for the kernel to own the fid while the cache needed it. Although its unlikely to ever be matched to anything else since its an "open" fid (so it won't be a candidate for a walk). It might be more secure to have it owned by some special constant (a NOUID which could be ~0) and marks the fid as being owned by the client and no one else without any sort of implication of authority/ownership. We could then put a special check in the find fid code to ignore any fids with NOUID. -eric