From: Eric Van Hensbergen <ericvh@gmail.com>
To: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
Cc: linux-fsdevel@vger.kernel.org, v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] :[RFC] [PATCH 6/7] [net/9p] Read and Write side zerocopy changes for 9P2000.L protocol.
Date: Wed, 9 Feb 2011 08:28:13 -0600 [thread overview]
Message-ID: <AANLkTikinBZr1ubgfQU2Z-v1EdrdL80Nnq+6STRxCtWo@mail.gmail.com> (raw)
In-Reply-To: <4D51F514.2060800@linux.vnet.ibm.com>
On Tue, Feb 8, 2011 at 7:59 PM, Venkateswararao Jujjuri (JV)
<jvrao@linux.vnet.ibm.com> wrote:
>>
>>> the implementations it should be really easy to shut me up with
>>> comparison data of zc and non-zc for 1, 64, 128, 256, 512, 1024, 2048,
>>> 4192 byte payloads (without caches enabled of course).
>>
>> I think this is good experiment will publish data.
>
> BTW, unless we have bigger msize with differentiating pdu sizes these experiments
> may not make sense.
>
Not sure I agree (at least in the 1-4k scale), we are measuring the
overhead of memcpy versus the overhead of mapping/pinning the
additional sg -- or am I not thinking clearly. Its possible... I have
not had coffee yet. I suppose with your small buffer patch series
there might be some performance differences due to different allocator
behavior, and while I don't think it'll be significant, it may be
worth re-doing the experiment once we have that in place.
Which brings up another question -- I know your team are doing
functional regressions, but are they also dong performance
regressions? Since we are starting into the optimization patches it
may not be a bad idea to track how the changes are impacting
scalability, latency, and throughput (as well as some metric of
resource consumption, but that may be a harder metric to track).
-eric
-eric
next prev parent reply other threads:[~2011-02-09 14:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 7:21 [RFC-V2] [PATCH 0/7] Zero Copy Venkateswararao Jujjuri (JV)
2011-02-07 6:55 ` Venkateswararao Jujjuri (JV)
2011-02-07 7:21 ` [RFC] [PATCH 1/7] [net/9p] Additional elements to p9_fcall to accomodate zero copy Venkateswararao Jujjuri (JV)
2011-02-07 7:21 ` Venkateswararao Jujjuri (JV)
2011-02-07 6:56 ` [RFC] [PATCH 2/7] [net/9p] Adds supporting functions for " Venkateswararao Jujjuri (JV)
2011-02-08 15:20 ` [V9fs-developer] " Latchesar Ionkov
2011-02-08 17:21 ` Venkateswararao Jujjuri (JV)
2011-02-07 7:21 ` [RFC] [PATCH 1/7] [net/9p] Additional elements to p9_fcall to accomodate " Venkateswararao Jujjuri (JV)
2011-02-07 6:56 ` [RFC] [PATCH 3/7] [net/9p] Assign type of transaction to tc->pdu->id which is otherwise unsed Venkateswararao Jujjuri (JV)
2011-02-07 7:21 ` [RFC] [PATCH 1/7] [net/9p] Additional elements to p9_fcall to accomodate zero copy Venkateswararao Jujjuri (JV)
2011-02-07 6:56 ` [RFC] [PATCH 4/7] [net/9p] Add gup/zero_copy support to VirtIO transport layer Venkateswararao Jujjuri (JV)
2011-02-07 7:21 ` [RFC] [PATCH 1/7] [net/9p] Additional elements to p9_fcall to accomodate zero copy Venkateswararao Jujjuri (JV)
2011-02-07 6:57 ` [RFC] [PATCH 5/7] [net/9p] Add preferences to transport layer Venkateswararao Jujjuri (JV)
2011-02-07 7:21 ` [RFC] [PATCH 1/7] [net/9p] Additional elements to p9_fcall to accomodate zero copy Venkateswararao Jujjuri (JV)
2011-02-07 6:57 ` :[RFC] [PATCH 6/7] [net/9p] Read and Write side zerocopy changes for 9P2000.L protocol Venkateswararao Jujjuri (JV)
2011-02-08 21:09 ` [V9fs-developer] " Eric Van Hensbergen
2011-02-08 21:16 ` Eric Van Hensbergen
2011-02-09 21:09 ` Venkateswararao Jujjuri (JV)
2011-02-09 21:12 ` Venkateswararao Jujjuri (JV)
2011-02-09 21:18 ` Eric Van Hensbergen
2011-02-09 21:39 ` Venkateswararao Jujjuri (JV)
2011-02-08 23:50 ` Venkateswararao Jujjuri (JV)
2011-02-09 1:59 ` Venkateswararao Jujjuri (JV)
2011-02-09 14:28 ` Eric Van Hensbergen [this message]
2011-02-07 7:21 ` [RFC] [PATCH 1/7] [net/9p] Additional elements to p9_fcall to accomodate zero copy Venkateswararao Jujjuri (JV)
2011-02-07 6:58 ` [PATCH 7/7] [net/9p] Handle TREAD/RERROR case in !dotl case Venkateswararao Jujjuri (JV)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikinBZr1ubgfQU2Z-v1EdrdL80Nnq+6STRxCtWo@mail.gmail.com \
--to=ericvh@gmail.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).