Re: [PATCH 0/29] Staging: Add yaffs2 filesystem

[Tracey Dent <tdent48227@gmail.com>]

On 11/1/10, Greg KH <greg@kroah.com> wrote:
> On Mon, Nov 01, 2010 at 03:36:13PM -0400, Tracey Dent wrote:
>> On 11/1/10, Charles Manning <manningc2@actrix.gen.nz> wrote:
>> > On Tuesday 02 November 2010 08:24:42 David Daney wrote:
>> >> On 11/01/2010 12:14 PM, Charles Manning wrote:
>> >> > On Tuesday 02 November 2010 07:55:39 David Daney wrote:
>> >> >> On 11/01/2010 11:40 AM, Tracey Dent wrote:
>> >> >>> The patch sets puts the yaffs2 filesystem in the staging directory.
>> >> >>> It is all based on Charles git
>> >> >>> tree(http://github.com/cdhmanning/linux-yaffs-integration/).
>> >> >>> Everything
>> >> >>> is compile tested and it builds.
>> >> >>>
>> >> >>> This only the inital support and I will be sending more cleanup
>> >> >>> patches.
>> >> >>>
>> >> >>> Greg can you add the patch set into your staging-next tree.
>> >> >>> Also, It doesn't affect anything other than itself.
>> >> >>>
>> >> >>> Thanks,
>> >> >>>
>> >> >>> Tracey Dent
>> >> >>
>> >> >> I am confused.
>> >> >>
>> >> >> Are you and Charles Manning working together on this?
>> >> >>
>> >> >> Did you write all this code or did Charles?  If it was Charles, why
>> >> >> are
>> >> >> there no From: and Signed-off-by headers for him?
>> >> >>
>> >> >> Thanks in advance for enlightening us as to what is going on here,
>> >> >> David Daney
>> >> >
>> >> > We are not working together on this, but I do appreciate the effort
>> >> > in
>> >> > helping bring to a head what people like/dislike.
>> >> >
>> >> > I am trying to keep the kernel yaffs consistent with the yaffs.net
>> >> > yaffs
>> >> > so that it is easier to add changes from yaffs.net.
>> >>
>> >> Great.  Thanks for clearing things up.
>> >>
>> >> I will offer my unsolicited opinion:
>> >>
>> >> Charles has obviously expended great effort on yaffs2.  He has a git
>> >> repository hosting the code, and has expressed a desire to get the code
>> >> fit for merging.  For Tracey Dent to come along and hijack the entire
>> >> effort, would anger me if I were in Charles' place.
>> >
>> > I don't see any malicious intent from Tracey, but I do wish to see some
>> > recognition for 8+ years of effort :-).
>> >
>>
>> I can resend it with your signed-off-by line instead of mine.
>
> You need to properly credit _who_ did the code in the first place.  And
> your patches did not do that at all, which is very bad, and rude, and
> something that we care deeply about.
>
> Please read the file, Documentation/SubmittingPatches for how to
> properly attribute the author of the patch when you send it out.
>
> I'm not going to take this as-is because of this problem, and neither
> will any other maintainer.  Someone can resend it with the proper author
> and signed-off-by stuff and I'll be glad to look at it again then.
>

Sorry for not giving credit. I will resend following patch set with
proper credits.

> thanks,
>
> greg k-h

Sorry,

Tracey Dent