Re: linux-next: Tree for January 15 (Call Trace in fs/dcache.c + autofs4)

[Sedat Dilek <sedat.dilek@googlemail.com>]

On Sat, Jan 15, 2011 at 12:16 PM, Sedat Dilek
<sedat.dilek@googlemail.com> wrote:
> On Sat, Jan 15, 2011 at 12:08 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>> On Sat, Jan 15, 2011 at 12:00:54PM +0100, Sedat Dilek wrote:
>>
>>> > Argh... ??In __do_follow_link() replace
>>> >
>>> > ?? ?? ?? ??if (link->mnt != nd->path.mnt)
>>> > with
>>> > ?? ?? ?? ??if (link->mnt == nd->path.mnt)
>>> >
>>> > Mismerge yesterday ;-/ ??I've pushed fix for that in for-next, will fold
>>> > shortly. ??As for autofs4 breakage, I've a preliminary fix, testing it
>>> > now.
>>> >
>>>
>>> Hey, cool and thanks.
>>>
>>> Not sure if you catched them all, I have noticed on my latest
>>> ("buggy") linux-next kernel these Call Traces when doing an
>>> update-grub.
>>
>> That might be vfsmount being dropped when it shouldn't or dentry leaked.
>> And seeing that it's umount(8), I would suspect the latter...
>>
>> Anyway, with the latest from dhowells we probably should have
>> d_set_d_op() mess on autofs4 under control (in #for-next).  Whether
>> it's enough to actually fix the sucker is a separate question, of
>> course - there might very well be more crap.
>>
>> I've instrumented mntput() et.al. here; hopefully that'll make catching
>> the remaining turds easier.  As for dcache leaks... ouch.  Could you
>> try to reproduce that one on the mainline kernel?  At least that'd
>> isolate things a bit.
>>
>
> Which version do you mean by "mainline"? 2.6.37-git12?
> And with "[mismerge][foldme] breakage in __do_follow_link()" patch [1]?
> I have to look by pulling-in(to) Linus-tree (linux-next) which patches
> are not merged already.
>
> - Sedat -
>
> [1] http://git.kernel.org/?p=linux/kernel/git/viro/vfs-2.6.git;a=commit;h=2f3740b3a80bc19498b3ec9b86a25d5941545436
>

OK, I will try with these two patches and report later.

- Sedat -

P.S.:

sd@tbox:~/src/linux-2.6/linux-2.6.37/debian/patches$ ls -l vfs-2.6-for-next/
insgesamt 28
-rw-r--r-- 1 sd sd  737 15. Jan 12:21
0001-mismerge-foldme-breakage-in-__do_follow_link.patch
-rw-r--r-- 1 sd sd 4446 15. Jan 12:21
0002-autofs4-Merge-the-remaining-dentry-ops-tables.patch
-rw-r--r-- 1 sd sd  201 15. Jan 12:21 diffstat
-rw-r--r-- 1 sd sd  232 15. Jan 12:21 Shortlog
-rw-r--r-- 1 sd sd 4417 15. Jan 12:21 vfs-2.6-for-next.patch