Re: [PATCH 24/29] Staging: yaffs2: yaffs_verify: Add files

[Pekka Enberg <penberg@kernel.org>]

On Mon, Nov 1, 2010 at 9:16 PM, Jesper Juhl <jj@chaosbits.net> wrote:
> On Mon, 1 Nov 2010, Tracey Dent wrote:
>
>> Adding files to yaffs2 directory.
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>> ---
>>  drivers/staging/yaffs2/yaffs_verify.c |  631 +++++++++++++++++++++++++++++++++
>>  drivers/staging/yaffs2/yaffs_verify.h |   41 +++
>>  2 files changed, 672 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/staging/yaffs2/yaffs_verify.c
>>  create mode 100644 drivers/staging/yaffs2/yaffs_verify.h
>>
>> diff --git a/drivers/staging/yaffs2/yaffs_verify.c b/drivers/staging/yaffs2/yaffs_verify.c
>> new file mode 100644
>> index 0000000..89e730b
>> --- /dev/null
>> +++ b/drivers/staging/yaffs2/yaffs_verify.c
> ...
>> +#if 0
>
> Why are you trying to merge new code that's under '#if 0' (and not just
> here, but elsewhere as well)?
> Either it shouldn't be here, in which case it should just be omitted from
> the patch, or it needs to be here eventually in which case it should be
> fixed up so the '#if 0' can go away or simply just be added later when it
> has been fixed up.

You can do all sorts of crazy things under drivers/staging. So no, the
code doesn't need to be cleaned up prior to merging. You are, however,
correct on what needs to be done for this piece of code to be promoted
to mainline proper at some point in time.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html