From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 24/29] Staging: yaffs2: yaffs_verify: Add files Date: Mon, 1 Nov 2010 21:30:14 +0200 Message-ID: References: <1288636877-7964-1-git-send-email-tdent48227@gmail.com> <1288636877-7964-25-git-send-email-tdent48227@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Tracey Dent , greg@kroah.com, manningc2@actrix.gen.nz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Jesper Juhl Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:42305 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286Ab0KATaP convert rfc822-to-8bit (ORCPT ); Mon, 1 Nov 2010 15:30:15 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 1, 2010 at 9:16 PM, Jesper Juhl wrote: > On Mon, 1 Nov 2010, Tracey Dent wrote: > >> Adding files to yaffs2 directory. >> >> Signed-off-by: Tracey Dent >> --- >> =A0drivers/staging/yaffs2/yaffs_verify.c | =A0631 ++++++++++++++++++= +++++++++++++++ >> =A0drivers/staging/yaffs2/yaffs_verify.h | =A0 41 +++ >> =A02 files changed, 672 insertions(+), 0 deletions(-) >> =A0create mode 100644 drivers/staging/yaffs2/yaffs_verify.c >> =A0create mode 100644 drivers/staging/yaffs2/yaffs_verify.h >> >> diff --git a/drivers/staging/yaffs2/yaffs_verify.c b/drivers/staging= /yaffs2/yaffs_verify.c >> new file mode 100644 >> index 0000000..89e730b >> --- /dev/null >> +++ b/drivers/staging/yaffs2/yaffs_verify.c > ... >> +#if 0 > > Why are you trying to merge new code that's under '#if 0' (and not ju= st > here, but elsewhere as well)? > Either it shouldn't be here, in which case it should just be omitted = from > the patch, or it needs to be here eventually in which case it should = be > fixed up so the '#if 0' can go away or simply just be added later whe= n it > has been fixed up. You can do all sorts of crazy things under drivers/staging. So no, the code doesn't need to be cleaned up prior to merging. You are, however, correct on what needs to be done for this piece of code to be promoted to mainline proper at some point in time. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html