From: Marco Stornelli <marco.stornelli@gmail.com>
To: Josh Hunt <johunt@akamai.com>
Cc: Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"sandeen@redhat.com" <sandeen@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC][PATCH] ext2: Resolve i_nlink race in ext2_rename
Date: Fri, 25 Feb 2011 08:38:15 +0100 [thread overview]
Message-ID: <AANLkTikmgaoBsf5neCxM9jYCJGkdAS1QC2k0zKUTW2=8@mail.gmail.com> (raw)
In-Reply-To: <4D66BD18.2030207@akamai.com>
Hi,
2011/2/24 Josh Hunt <johunt@akamai.com>:
> Jan
>
> I'm not seeing the problem with your patch as was expected since we're
> not messing with i_nlink anymore. Al suggested marking the inode as
> dirty where we were previously doing the old_inode dec. I believe this
> is needed as well since we are updating it's ctime. I've attached a
> version marking the inode dirty and it also fixes the comment making
> reference to calling inode_dec_link_count().
>
> I'm not completely clear on the historical reasons for messing with the
> link count of old_inode in the first place. It was just to simulate the
> linking and unlinking of the old_inode?
>
> Thanks
> Josh
>
can we share your test/benchmark? I'd like to add it to my test suite
as no-regression test.
Marco
next prev parent reply other threads:[~2011-02-25 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 6:21 [RFC][PATCH] ext2: Resolve i_nlink race in ext2_rename Josh Hunt
2011-02-24 6:37 ` Al Viro
2011-02-24 6:42 ` fat64 implementation Keshava Munegowda
2011-02-24 11:20 ` [RFC][PATCH] ext2: Resolve i_nlink race in ext2_rename Jan Kara
2011-02-24 20:18 ` Josh Hunt
2011-02-25 7:38 ` Marco Stornelli [this message]
2011-02-28 17:57 ` Jan Kara
2011-02-28 20:17 ` Josh Hunt
2011-02-28 20:56 ` Jan Kara
2011-03-01 12:15 ` Al Viro
2011-03-01 11:07 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2011-02-22 23:42 Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikmgaoBsf5neCxM9jYCJGkdAS1QC2k0zKUTW2=8@mail.gmail.com' \
--to=marco.stornelli@gmail.com \
--cc=jack@suse.cz \
--cc=johunt@akamai.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).