From: Changli Gao <xiaosuo@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] splice: allow non-block splice only when in file is seekable
Date: Wed, 26 May 2010 19:53:53 +0800 [thread overview]
Message-ID: <AANLkTildR17ccf4TAT0GavB6BoethCqg8BrqBPFu8s0N@mail.gmail.com> (raw)
In-Reply-To: <E1OHDru-0000Ge-Lr@pomaz-ex.szeredi.hu>
On Wed, May 26, 2010 at 6:29 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Wed, 26 May 2010, Changli Gao wrote:
>> allow non-block splice only when in file is seekable.
>>
>> do_splice_to() is split to two parts: read data from in file to spd, and move
>> data from spd to pipe. If there isn't much space in pipe for the data in spd,
>> and the splice is called with non-block flag, the data dropped due to non
>> enough space in pipe will be lost forever when in file isn't seekable.
>
> This is a gratuitous ABI change. I don't think we should hold the
> hand of application writers,
Yea, it is an ABI change. But without that, we'll fail user silently
currently. Some fundamental change is needed to fix this issue fully,
if you think it is a bug.
> maybe they _know_ the splice will not
> block.
>
If they know the splice won't block, why he specifies a non-block flag?
--
Regards，
Changli Gao(xiaosuo@gmail.com)
next prev parent reply other threads:[~2010-05-26 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 9:56 [PATCH 2/3] splice: allow non-block splice only when in file is seekable Changli Gao
2010-05-26 10:29 ` Miklos Szeredi
2010-05-26 11:53 ` Changli Gao [this message]
2010-05-26 12:23 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTildR17ccf4TAT0GavB6BoethCqg8BrqBPFu8s0N@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).