From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do Date: Wed, 3 Nov 2010 08:58:56 +0200 Message-ID: References: <201009161632.59210.arnd@arndb.de> <201010192140.47433.oliver@neukum.org> <20101019202912.GA30133@kroah.com> <201010192244.41913.arnd@arndb.de> <20101102012135.GB2648@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Arnd Bergmann , Greg KH , Oliver Neukum , Valdis.Kletnieks@vt.edu, Dave Airlie , codalist@telemann.coda.cs.cmu.edu, ksummit-2010-discuss@lists.linux-foundation.org, autofs@linux.kernel.org, Jan Harkes , Samuel Ortiz , Jan Kara , Arnaldo Carvalho de Melo , netdev@vger.kernel.org, Anders Larsen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bryan Schumaker , Christoph Hellwig , Petr Vandrovec , Mikulas Patocka , linux-fsdevel@vger.kernel.org, Evgeniy Dushistov , Ingo Molnar , Andrew Hendry , linux-media@vger.kernel.org To: Pavel Machek Return-path: In-Reply-To: <20101102012135.GB2648@ucw.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Nov 2, 2010 at 3:21 AM, Pavel Machek wrote: > Hi! > >> @@ -79,6 +79,10 @@ static struct drm_driver driver =3D { >> >> =A0static int __init i810_init(void) >> =A0{ >> + =A0 =A0 if (num_present_cpus() > 1) { >> + =A0 =A0 =A0 =A0 =A0 =A0 pr_err("drm/i810 does not support SMP\n"); >> + =A0 =A0 =A0 =A0 =A0 =A0 return -EINVAL; >> + =A0 =A0 } >> =A0 =A0 =A0 driver.num_ioctls =3D i810_max_ioctl; >> =A0 =A0 =A0 return drm_init(&driver); > > Umm, and now someone onlines second cpu? Well, I see it's being fixed in a different way but yeah, num_possible_cpus() would be more appropriate here.