From: shenghui <crosslonelyover@gmail.com>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@redhat.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-mm@kvack.org, linux-ext4 <linux-ext4@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0
Date: Tue, 20 Jul 2010 09:04:46 +0800 [thread overview]
Message-ID: <AANLkTimBCrq8cPJrTSKiG_wbd1ppu0twTAMXeezJEZs3@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimh4UjM3LWPjBjMA5UGecQYyPSxIvJBInijAP-j@mail.gmail.com>
2010/7/20 shenghui <crosslonelyover@gmail.com>:
> 2010/7/20 Andreas Gruenbacher <agruen@suse.de>:
>
> Sorry, I haven't found any special attention on
> sysctl_vfs_cache_pressure == 0 case or scale
> nr_to_scan in fs/dcache.c
>
> 900static int shrink_dcache_memory(int nr, gfp_t gfp_mask)
> 901{
> 902 if (nr) {
> 903 if (!(gfp_mask & __GFP_FS))
> 904 return -1;
> 905 prune_dcache(nr);
> 906 }
> 907 return (dentry_stat.nr_unused / 100) * sysctl_vfs_cache_pressure;
> 908}
>
And for sysctl_vfs_cache_pressure == 0 case, it's
enough to return 0 to indicate no cache entries left.
--
Thanks and Best Regards,
shenghui
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-07-20 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 1:01 [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Wang Sheng-Hui
2010-07-18 4:06 ` Eric Sandeen
2010-07-18 6:01 ` Christoph Hellwig
2010-07-18 6:36 ` Wang Sheng-Hui
2010-07-19 18:39 ` Andreas Gruenbacher
2010-07-20 1:02 ` shenghui
2010-07-20 1:04 ` shenghui [this message]
2010-07-20 15:13 ` Eric Sandeen
2010-07-20 16:34 ` Andreas Gruenbacher
2010-07-19 18:40 ` Andreas Gruenbacher
-- strict thread matches above, loose matches on Subject: below --
2010-07-21 10:53 Wang Sheng-Hui
2010-07-21 14:00 ` Eric Sandeen
2010-07-22 0:54 Wang Sheng-Hui
2010-07-22 1:06 ` shenghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimBCrq8cPJrTSKiG_wbd1ppu0twTAMXeezJEZs3@mail.gmail.com \
--to=crosslonelyover@gmail.com \
--cc=agruen@suse.de \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).