From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard -rw- weinberger Subject: Re: [PATCH 2/6 v6] vfs: export do_splice_direct() to modules Date: Tue, 1 Mar 2011 16:49:07 +0100 Message-ID: References: <20110301123645.189703316@szeredi.hu> <20110301123701.955702964@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, apw@canonical.com To: Miklos Szeredi Return-path: In-Reply-To: <20110301123701.955702964@szeredi.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Miklos, On Tue, Mar 1, 2011 at 1:36 PM, Miklos Szeredi wrot= e: > From: Miklos Szeredi > > Export do_splice_direct() to modules. =A0Needed by overlay filesystem= =2E > > Signed-off-by: Miklos Szeredi > --- > =A0fs/splice.c | =A0 =A01 + > =A01 file changed, 1 insertion(+) > > Index: linux-2.6/fs/splice.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- linux-2.6.orig/fs/splice.c =A02011-02-22 11:04:39.000000000 +0100 > +++ linux-2.6/fs/splice.c =A0 =A0 =A0 2011-03-01 12:18:16.000000000 += 0100 > @@ -1296,6 +1296,7 @@ long do_splice_direct(struct file *in, l > > =A0 =A0 =A0 =A0return ret; > =A0} > +EXPORT_SYMBOL(do_splice_direct); I have a question on your patch, why are you using EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL()? Are you using EXPORT_SYMBOL() because all symbols in fs/splice.c are exported via EXPORT_SYMBOL()? To be more precise, are there any rules to decide when _GPL() should be= used? IMHO we should always use _GPL() for new symbols. > =A0static int splice_pipe_to_pipe(struct pipe_inode_info *ipipe, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct pi= pe_inode_info *opipe, > > -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-kerne= l" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > Please read the FAQ at =A0http://www.tux.org/lkml/ > --=20 Thanks, //richard