From: Sedat Dilek <sedat.dilek@googlemail.com>
To: Nick Piggin <npiggin@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
systemd-devel@lists.freedesktop.org, eparis@redhat.com
Subject: Re: [patch] cgroup fs: avoid switching ->d_op on live dentry
Date: Tue, 21 Dec 2010 14:35:05 +0100 [thread overview]
Message-ID: <AANLkTim_ninC_sGJy-5cT89og24aM3=Z--hRvVaAttoA@mail.gmail.com> (raw)
In-Reply-To: <20101221085538.GA9133@amd>
On Tue, Dec 21, 2010 at 9:55 AM, Nick Piggin <npiggin@kernel.dk> wrote:
> On Tue, Dec 21, 2010 at 09:44:40AM +0100, Sedat Dilek wrote:
>> Against linux-next (next-20101210) it should look like:
>
> Yep, I'll rebase my tree with the fix shortly.
>
>>
>> $ diff -Naur cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
>> cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
>> --- cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
>> 2010-12-21 09:31:38.649601964 +0100
>> +++ cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
>> 2010-12-21 09:40:21.151033232 +0100
>> @@ -83,7 +83,7 @@
>> inode->i_size = 0;
>> inode->i_fop = &cgroup_file_operations;
>> }
>> -- dentry->d_op = &cgroup_dops;
>> +- d_set_d_op(dentry, &cgroup_dops);
>> d_instantiate(dentry, inode);
>> dget(dentry); /* Extra count - pin the dentry in core */
>> return 0;
>>
>> - Sedat -
>
I just started the compilation due to slow kernel mirrors, I see this warning:
$ egrep 'kernel/cgroup.o|kernel/cgroup.c'
build_linux-next_next20101221.dileks.1.log
CC kernel/cgroup.o
/home/sd/src/linux-2.6/linux-2.6.37-rc6/debian/build/source_i386_none/kernel/cgroup.c:
In function ‘cgroup_lookup’:
/home/sd/src/linux-2.6/linux-2.6.37-rc6/debian/build/source_i386_none/kernel/cgroup.c:2219:3:
warning: initialization from incompatible pointer type
[ kernel/cgroup.c ]
...
static int cgroup_delete_dentry(struct dentry *dentry)
{
return 1;
}
static struct dentry *cgroup_lookup(struct inode *dir,
struct dentry *dentry, struct nameidata *nd)
{
static const struct dentry_operations cgroup_dentry_operations = {
.d_delete = cgroup_delete_dentry, <--- LINE #2219
.d_iput = cgroup_diput,
};
if (dentry->d_name.len > NAME_MAX)
return ERR_PTR(-ENAMETOOLONG);
dentry->d_op = &cgroup_dentry_operations;
d_add(dentry, NULL);
return NULL;
}
...
Can you fix that with your rebasing, too?
Thanks in advance.
- Sedat -
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
next prev parent reply other threads:[~2010-12-21 13:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 8:44 [patch] cgroup fs: avoid switching ->d_op on live dentry Sedat Dilek
2010-12-21 8:55 ` Nick Piggin
2010-12-21 13:35 ` Sedat Dilek [this message]
2010-12-21 18:25 ` Al Viro
2010-12-21 18:57 ` Sedat Dilek
2010-12-22 3:11 ` Nick Piggin
2010-12-22 3:31 ` Sedat Dilek
2010-12-22 4:38 ` Sedat Dilek
2010-12-21 15:12 ` Sedat Dilek
2010-12-21 15:28 ` Sedat Dilek
2010-12-21 17:56 ` Sedat Dilek
-- strict thread matches above, loose matches on Subject: below --
2010-12-21 7:12 Nick Piggin
2010-12-21 9:04 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim_ninC_sGJy-5cT89og24aM3=Z--hRvVaAttoA@mail.gmail.com' \
--to=sedat.dilek@googlemail.com \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=sedat.dilek@gmail.com \
--cc=systemd-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).