From: Nick Piggin <npiggin@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Nick Piggin <npiggin@kernel.dk>,
sedat.dilek@gmail.com, systemd-devel@lists.freedesktop.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org,
eparis@redhat.com
Subject: Re: [patch] cgroup fs: avoid switching ->d_op on live dentry
Date: Wed, 22 Dec 2010 14:11:51 +1100 [thread overview]
Message-ID: <AANLkTima4usWhhT-QOJcmeXv+rBA95YL8QaYpOs-w2oW@mail.gmail.com> (raw)
In-Reply-To: <20101221182551.GL19804@ZenIV.linux.org.uk>
On Wed, Dec 22, 2010 at 5:25 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, Dec 21, 2010 at 07:55:38PM +1100, Nick Piggin wrote:
>> On Tue, Dec 21, 2010 at 09:44:40AM +0100, Sedat Dilek wrote:
>> > Against linux-next (next-20101210) it should look like:
>>
>> Yep, I'll rebase my tree with the fix shortly.
>>
>> >
>> > $ diff -Naur cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
>> > cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
>> > --- cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
>> > 2010-12-21 09:31:38.649601964 +0100
>> > +++ cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
>> > 2010-12-21 09:40:21.151033232 +0100
>> > @@ -83,7 +83,7 @@
>> > inode->i_size = 0;
>> > inode->i_fop = &cgroup_file_operations;
>> > }
>> > -- dentry->d_op = &cgroup_dops;
>> > +- d_set_d_op(dentry, &cgroup_dops);
>> > d_instantiate(dentry, inode);
>> > dget(dentry); /* Extra count - pin the dentry in core */
>> > return 0;
>
> How about not doing that d_set_d_op() at all? See #d_op in vfs-2.6.git;
> just set ->s_d_op to that once and be done with that. No need to reassign
> it on a live dentry...
It shouldn't be live there after my patch, but either way it is fixed,
doesn't matter. Your s_d_op patch allows more reuse of code, so
that looks nicer.
next prev parent reply other threads:[~2010-12-22 3:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 8:44 [patch] cgroup fs: avoid switching ->d_op on live dentry Sedat Dilek
2010-12-21 8:55 ` Nick Piggin
2010-12-21 13:35 ` Sedat Dilek
2010-12-21 18:25 ` Al Viro
2010-12-21 18:57 ` Sedat Dilek
2010-12-22 3:11 ` Nick Piggin [this message]
2010-12-22 3:31 ` Sedat Dilek
2010-12-22 4:38 ` Sedat Dilek
2010-12-21 15:12 ` Sedat Dilek
2010-12-21 15:28 ` Sedat Dilek
2010-12-21 17:56 ` Sedat Dilek
-- strict thread matches above, loose matches on Subject: below --
2010-12-21 7:12 Nick Piggin
2010-12-21 9:04 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTima4usWhhT-QOJcmeXv+rBA95YL8QaYpOs-w2oW@mail.gmail.com \
--to=npiggin@gmail.com \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=sedat.dilek@gmail.com \
--cc=systemd-devel@lists.freedesktop.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).