From: Nick Piggin <npiggin@gmail.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@kernel.dk>,
"Chen, Tim C" <tim.c.chen@intel.com>
Subject: Re: more dput lock contentions in 2.6.38-rc?
Date: Tue, 25 Jan 2011 12:26:38 +1100 [thread overview]
Message-ID: <AANLkTimwSNsjR5PnVP8JvzwEBwy3VtDp4DvNecKsTnxJ@mail.gmail.com> (raw)
In-Reply-To: <1295917864.1949.970.camel@sli10-conroe>
On Tue, Jan 25, 2011 at 12:11 PM, Shaohua Li <shaohua.li@intel.com> wrote:
> On Tue, 2011-01-25 at 09:04 +0800, Nick Piggin wrote:
>> On Tue, Jan 25, 2011 at 11:35 AM, Shaohua Li <shaohua.li@intel.com> wrote:
>> > Hi,
>> > we are testing dbench benchmark and see big drop of 2.6.38-rc compared
>> > to 2.6.37 in several machines with 2 sockets or 4 sockets. We have 12
>> > disks mount to /mnt/stp/dbenchdata/sd*/ and dbench runs against data of
>> > the disks. According to perf, we saw more lock contentions:
>> > In 2.6.37: 13.00% dbench [kernel.kallsyms] [k] _raw_spin_lock
>> > In 2.6.38-rc: 69.45% dbench [kernel.kallsyms] [k]_raw_spin_lock
>> > - 69.45% dbench [kernel.kallsyms] [k] _raw_spin_lock
>> > - _raw_spin_lock
>> > - 48.41% dput
>> > - 61.17% path_put
>> > - 60.47% do_path_lookup
>> > + 53.18% user_path_at
>> > + 42.13% do_filp_open
>> > + 4.69% user_path_parent
>>
>> What filesystems are mounted on the path?
> ext3 or ext4
ext3 or 4 along every step of the path? Are there
any acls loaded, or security policy running?
It may be possible that they're all coming from
/proc/ access.
>
>> > - 35.56% d_path
>> > seq_path
>> > show_vfsmnt
>> > seq_read
>> > vfs_read
>> > sys_read
>> > system_call_fastpath
>> > __GI___libc_read
>>
>> This guy is from glibc's statvfs call that dbench uses. It
>> parses /proc/mounts for mount flags which is racy (and
>> not a good idea to do with any frequency).
>>
>> A patch went into the kernel that allows glibc to get the
>> flags directly. Not sure about glibc status, I imagine it
>> will get there in another decade or two... Can you try
>> commenting it out of dbench source code?
> Sure, maybe after Chinese new year holiday, sorry.
No problem.
Thanks,
Nick
next prev parent reply other threads:[~2011-01-25 1:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 0:35 more dput lock contentions in 2.6.38-rc? Shaohua Li
2011-01-25 1:04 ` Nick Piggin
2011-01-25 1:11 ` Shaohua Li
2011-01-25 1:26 ` Nick Piggin [this message]
2011-01-25 1:34 ` Shaohua Li
2011-01-25 1:44 ` Nick Piggin
2011-01-25 2:01 ` Shaohua Li
2011-01-25 2:09 ` Nick Piggin
2011-01-25 2:46 ` Shaohua Li
2011-01-25 3:04 ` Nick Piggin
2011-02-23 3:26 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimwSNsjR5PnVP8JvzwEBwy3VtDp4DvNecKsTnxJ@mail.gmail.com \
--to=npiggin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=shaohua.li@intel.com \
--cc=tim.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).