Re: [V9fs-developer] [PATCH 1/5] [net/9p] Add capability() to p9_trans_module

[Latchesar Ionkov <lucho@ionkov.net>]

Or call the function once when the client is created and store the
value in the client struct. I don't think the call will be inlined.

Thanks,
    Lucho

On Tue, Aug 17, 2010 at 2:43 PM, Eric Van Hensbergen <ericvh@gmail.com> wrote:
> On Tue, Aug 17, 2010 at 12:27 PM, Venkateswararao Jujjuri (JV)
> <jvrao@linux.vnet.ibm.com> wrote:
>> Every transport layer may have unique capabilities. This function is employed
>> to query and make use of those special/unique cabailities.
>> To start with we will be defining P9_CAP_GET_MAX_SG_PAGES.
>> If capability(P9_CAP_GET_MAX_SG_PAGES) exists AND returns a value greater
>> than 0, it means that the transport can support the transportation
>> of that many mapped pages between the client and server.
>>
>
> Is there a good reason to make this a function versus a flag/bit-mask
> in the transport structure?  Having to call an extra function
> (hopefully it gets inlined, but its function pointer so I'm thinking
> it won't) every client_rpc call seems like a mistake.
>
> Additionally, given we know the page size constant, couldn't we infer
> this from a negotiated msize?  Transports already have an maxsize
> field which limits the msize selections (and defaults? if not maybe it
> should?) -- why not just use that?
>
>      -eric
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by
>
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge
> http://p.sf.net/sfu/RIM-dev2dev
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html