From: Changli Gao <xiaosuo@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: viro@zeniv.linux.org.uk, matthew@wil.cx,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] sendfile: fix sendfile
Date: Wed, 26 May 2010 19:59:45 +0800 [thread overview]
Message-ID: <AANLkTimyIyPbPd2yCuVNR6OImnFnIIxizE1ncY3ISMNH@mail.gmail.com> (raw)
In-Reply-To: <E1OHEA9-0000Mv-8r@pomaz-ex.szeredi.hu>
On Wed, May 26, 2010 at 6:48 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
>
>>
>> If output file is in non-block mode, in file should be seekable to avoid data
>> losing.
>
> Like the previous patch, I don't agree.
I don't think it isn't an API change, as the current manual page says:
" Presently (Linux 2.6.9): in_fd, must correspond to a file which sup-
ports mmap(2)-like operations (i.e., it cannot be a socket); "
and if file supports mmap-like operations, it should support pread too.
>
>>
>> do_splice_from() shouldn't use sd->pos, as sd->pos is for file reading,
>> file->f_pos should be used instead.
>
> This sounds sane.
>
> These changes look like three cadidates for separate patches. Could
> you please split this patch up, and submit the first and last change
> as a separate patch?
>
OK. I'll do that later after all the issues are concluded.
--
Regards，
Changli Gao(xiaosuo@gmail.com)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-05-26 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 9:56 [PATCH 3/3] sendfile: fix sendfile Changli Gao
2010-05-26 10:48 ` Miklos Szeredi
2010-05-26 11:59 ` Changli Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimyIyPbPd2yCuVNR6OImnFnIIxizE1ncY3ISMNH@mail.gmail.com \
--to=xiaosuo@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).