From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH v1.2 0/5] IMA: making i_readcount a first class inode citizen (reposting) Date: Thu, 18 Nov 2010 15:31:10 -0800 Message-ID: References: <1290121382-4039-1-git-send-email-zohar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, jmorris@namei.org, akpm@linux-foundation.org, eparis@redhat.com, viro@zeniv.linux.org.uk, Dave Chinner , "J. Bruce Fields" , David Safford To: Mimi Zohar Return-path: In-Reply-To: <1290121382-4039-1-git-send-email-zohar@linux.vnet.ibm.com> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Nov 18, 2010 at 3:02 PM, Mimi Zohar = wrote: > > This patchset separates the incrementing/decrementing of the i_readco= unt, in > the VFS layer, from other IMA functionality, by replacing the current > ima_counts_get() call with i_readcount_inc(). Its unclear whether thi= s call to > increment i_readcount should be made earlier, like i_writecount. =A0C= urrently the > call is situated immediately after the switch from put_filp() to fput= () for > cleanup. Well, it seems nicer than the situation we have now. So I'm certainly ok with seeing this merged for 2.6.38 (through the security tree?) if nobody has objections. It's a bit sad to have another atomic in the open path, but if the lease people want this and are ok with just the counter (no races?) then it seems worth it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-securit= y-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html